All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Avoid potential NULL deref in scripts/genksyms/lex.l
@ 2007-06-24 21:40 Jesper Juhl
  2007-06-24 21:58 ` Andrew Morton
  0 siblings, 1 reply; 5+ messages in thread
From: Jesper Juhl @ 2007-06-24 21:40 UTC (permalink / raw)
  To: Richard Henderson; +Cc: Linux Kernel Mailing List, Andrew Morton, Jesper Juhl

strchr() returns NULL in case the string is not found and if that 
happens we risk dereferencing a NULL pointer. It never hurts to 
check for that condition and exit normally with an error rather 
than crashing.

(no, the indentation is not according to CodingStyle, it's simply 
 following whatever else is in that file)


Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
---

 scripts/genksyms/lex.l        |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/scripts/genksyms/lex.l b/scripts/genksyms/lex.l
index 5e544a0..28edc0c 100644
--- a/scripts/genksyms/lex.l
+++ b/scripts/genksyms/lex.l
@@ -154,6 +154,8 @@ repeat:
 
       file = strchr(yytext, '\"')+1;
       e = strchr(file, '\"');
+      if (!file || !e)
+	exit(1);
       *e = '\0';
       cur_filename = memcpy(xmalloc(e-file+1), file, e-file+1);
       cur_line = atoi(yytext+2);

^ permalink raw reply related	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2007-06-24 23:08 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-06-24 21:40 [PATCH] Avoid potential NULL deref in scripts/genksyms/lex.l Jesper Juhl
2007-06-24 21:58 ` Andrew Morton
2007-06-24 22:02   ` Jesper Juhl
2007-06-24 23:00     ` Andrew Morton
2007-06-24 23:08       ` Jesper Juhl

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.