All of lore.kernel.org
 help / color / mirror / Atom feed
From: Al Viro <viro@ftp.linux.org.uk>
To: Segher Boessenkool <segher@kernel.crashing.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	linux-kernel@vger.kernel.org, linux-sparse@vger.kernel.org
Subject: Re: [PATCH 16/16] fix handling of integer constant expressions
Date: Sun, 24 Jun 2007 19:44:49 +0100	[thread overview]
Message-ID: <20070624184449.GB21478@ftp.linux.org.uk> (raw)
In-Reply-To: <b739fb9ad6e68bfe5d2a4b839abc8ea4@kernel.crashing.org>

On Sun, Jun 24, 2007 at 08:18:52PM +0200, Segher Boessenkool wrote:
> >#define _IOC_TYPECHECK(t) \
> >        ((sizeof(t) == sizeof(t[1]) && \
> >          sizeof(t) < (1 << _IOC_SIZEBITS)) ? \
> >          sizeof(t) : __invalid_size_argument_for_IOC)
> >poisoning _IOW() et.al., so those who do something like
> >
> >static const char *v4l1_ioctls[] = {
> >        [_IOC_NR(VIDIOCGCAP)]       = "VIDIOCGCAP",
> >
> >run into trouble.
> 
> >The only reason that doesn't break gcc to hell and back is
> >that gcc has unfixed bugs in that area.
> 
> If I understand correctly what bugs you are talking about,
> most (all?) of those were solved in the dark ages already
> (i.e., the 3.x series).

Alas, no.  gcc is amazingly (and inconsistently) sloppy about the
things it accepts as integer constant expressions.
 
> >It certainly is not a valid C
> 
> Why not?  Nothing in the C standard says all your externs
> have to be defined in some other translation unit you link
> with AFAIK.

It's not about externs.  It's about things like

unsigned n;
int a[] = {[n - n + n - n] = 1};

And yes, gcc does eat that.  With -pedantic -std=c99, at that.  
However, 

unsigned n;
int a[] = {[n + n - n - n] = 1};

gets you error: nonconstant array index in initializer

And that's 4.1, not 3.x...

  reply	other threads:[~2007-06-24 18:44 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-24  8:05 [PATCH 16/16] fix handling of integer constant expressions Al Viro
2007-06-24 17:47 ` Al Viro
2007-06-24 18:04   ` Linus Torvalds
2007-06-24 18:35     ` Al Viro
2007-06-24 19:04       ` Linus Torvalds
2007-06-24 19:40         ` Segher Boessenkool
2007-06-24 20:38           ` Al Viro
2007-06-24 21:42             ` Neil Booth
2007-06-24 23:07               ` Al Viro
2007-06-25  6:16               ` Segher Boessenkool
2007-06-25  5:31             ` Josh Triplett
2007-06-25 19:55               ` Al Viro
2007-06-26  3:12                 ` Josh Triplett
2007-06-26 22:10               ` Al Viro
2007-06-26 22:10                 ` Al Viro
2007-06-26 22:11                 ` Al Viro
2007-06-26 22:11                   ` Al Viro
2007-06-26 23:32                   ` Neil Booth
2007-06-27  0:18                     ` Al Viro
2007-06-27  0:25                       ` Linus Torvalds
2007-06-27  0:37                         ` Al Viro
2007-06-27  0:29                       ` Derek M Jones
2007-06-27  0:41                         ` Al Viro
2007-06-27 11:52                       ` Neil Booth
2007-06-27 12:19                         ` Al Viro
2007-06-27 12:26                           ` Neil Booth
2007-06-27 12:37                             ` Al Viro
2007-06-27 12:10                   ` Neil Booth
2007-06-27 12:30                     ` Al Viro
2007-06-27 12:59                       ` Neil Booth
2007-06-27 13:18                         ` Al Viro
2007-06-27 13:35                           ` Neil Booth
2007-06-27 14:06                             ` Al Viro
2007-06-27 15:54                               ` Al Viro
2007-06-27 14:50                           ` Josh Triplett
2007-06-27 14:59                             ` Al Viro
2007-06-27 16:19                     ` Linus Torvalds
2007-06-27 16:34                       ` Josh Triplett
2007-06-27 17:25                         ` Al Viro
2007-06-27 17:29                       ` Al Viro
2007-06-27 17:45                         ` Linus Torvalds
2007-06-27 18:04                           ` Al Viro
2007-06-27 22:50                       ` Neil Booth
2007-06-28  9:08                       ` Segher Boessenkool
2007-06-26 22:49                 ` Josh Triplett
2007-06-25  6:13             ` Segher Boessenkool
2007-06-24 19:59         ` Al Viro
2007-06-24 18:07   ` Arnd Bergmann
2007-06-24 19:10     ` Al Viro
2007-06-24 18:18   ` Segher Boessenkool
2007-06-24 18:44     ` Al Viro [this message]
2007-06-24 19:09       ` Segher Boessenkool

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070624184449.GB21478@ftp.linux.org.uk \
    --to=viro@ftp.linux.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sparse@vger.kernel.org \
    --cc=segher@kernel.crashing.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.