From: olof@lixom.net (Olof Johansson)
To: linux-kernel@vger.kernel.org, linux-pcmcia@lists.infradead.org
Cc: akpm@osdl.org, linuxppc-dev@ozlabs.org, paulus@samba.org
Subject: [PATCH] pcmcia: ppc64 needs 32-bit ioaddr_t
Date: Sun, 24 Jun 2007 19:54:39 -0500 [thread overview]
Message-ID: <20070625005439.GA31289@lixom.net> (raw)
ppc64 really needs ioaddr_t to be 32-bit, since I/O addresses really are
MMIO addresses, and remapped at an offset that's well above 16 bits in
some cases.
While the type is exported to userspace, there hasn't been any platforms
with PCMCIA on 64-bit powerpc until now, so changing it won't regress
any existing users.
Signed-off-by: Olof Johansson <olof@lixom.net>
Acked-by: Paul Mackerras <paulus@samba.org>
Index: 2.6.21/include/pcmcia/cs_types.h
===================================================================
--- 2.6.21.orig/include/pcmcia/cs_types.h
+++ 2.6.21/include/pcmcia/cs_types.h
@@ -21,7 +21,7 @@
#include <sys/types.h>
#endif
-#if defined(__arm__) || defined(__mips__)
+#if defined(__arm__) || defined(__mips__) || defined(__powerpc64__)
/* This (ioaddr_t) is exposed to userspace & hence cannot be changed. */
typedef u_int ioaddr_t;
#else
WARNING: multiple messages have this Message-ID (diff)
From: olof@lixom.net (Olof Johansson)
To: linux-kernel@vger.kernel.org, linux-pcmcia@lists.infradead.org
Cc: paulus@samba.org, linuxppc-dev@ozlabs.org, akpm@osdl.org
Subject: [PATCH] pcmcia: ppc64 needs 32-bit ioaddr_t
Date: Sun, 24 Jun 2007 19:54:39 -0500 [thread overview]
Message-ID: <20070625005439.GA31289@lixom.net> (raw)
ppc64 really needs ioaddr_t to be 32-bit, since I/O addresses really are
MMIO addresses, and remapped at an offset that's well above 16 bits in
some cases.
While the type is exported to userspace, there hasn't been any platforms
with PCMCIA on 64-bit powerpc until now, so changing it won't regress
any existing users.
Signed-off-by: Olof Johansson <olof@lixom.net>
Acked-by: Paul Mackerras <paulus@samba.org>
Index: 2.6.21/include/pcmcia/cs_types.h
===================================================================
--- 2.6.21.orig/include/pcmcia/cs_types.h
+++ 2.6.21/include/pcmcia/cs_types.h
@@ -21,7 +21,7 @@
#include <sys/types.h>
#endif
-#if defined(__arm__) || defined(__mips__)
+#if defined(__arm__) || defined(__mips__) || defined(__powerpc64__)
/* This (ioaddr_t) is exposed to userspace & hence cannot be changed. */
typedef u_int ioaddr_t;
#else
next reply other threads:[~2007-06-25 0:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-25 0:54 Olof Johansson [this message]
2007-06-25 0:54 ` [PATCH] pcmcia: ppc64 needs 32-bit ioaddr_t Olof Johansson
2007-06-25 1:35 ` Arnd Bergmann
2007-06-25 1:35 ` Arnd Bergmann
2007-06-25 2:42 ` Olof Johansson
2007-06-25 2:42 ` Olof Johansson
2007-06-25 5:53 ` Christoph Hellwig
2007-06-25 5:53 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070625005439.GA31289@lixom.net \
--to=olof@lixom.net \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pcmcia@lists.infradead.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.