All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Wilcox <matthew@wil.cx>
To: David Woodhouse <dwmw2@infradead.org>
Cc: Russell King <rmk@arm.linux.org.uk>,
	Andrew Morton <akpm@linux-foundation.org>,
	torvalds@linux-foundation.org, paulus@samba.org,
	linux-arch@vger.kernel.org, drepper@redhat.com
Subject: Re: Introduce fixed sys_sync_file_range2() syscall, implement on PowerPC and ARM
Date: Mon, 25 Jun 2007 05:47:42 -0600	[thread overview]
Message-ID: <20070625114742.GG22063@parisc-linux.org> (raw)
In-Reply-To: <1182771454.12109.71.camel@pmac.infradead.org>

On Mon, Jun 25, 2007 at 12:37:34PM +0100, David Woodhouse wrote:
> - Some architectures must align 64-bit integers into an aligned
>   pair of registers. A slot may be wasted for padding.
> - S390 may not have a 64-bit integer in slots 5/6.

Uhm, doesn't sys_sync_file_range2 break that?

+asmlinkage long compat_sys_sync_file_range2(int fd, unsigned int flags,
+                                  unsigned offset_hi, unsigned offset_lo,
+                                  unsigned nbytes_hi, unsigned nbytes_lo)

How about:

asmlinkage long compat_sys_sync_file_range2(unsigned offset_hi,
		unsigned offset_lo, unsigned nbytes_hi, unsigned nbytes_lo, 
		int fd, unsigned int flags)

Also, you might want to put something in the syscall file about signed
vs unsigned arguments and how they behave with 32-on-64 systems.

  reply	other threads:[~2007-06-25 11:47 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-25  8:49 Introduce fixed sys_sync_file_range2() syscall, implement on PowerPC and ARM David Woodhouse
2007-06-25  9:11 ` Andrew Morton
2007-06-25  9:48   ` David Woodhouse
2007-06-25 10:24     ` Matthew Wilcox
2007-06-25 10:35   ` Matthew Wilcox
2007-06-25 11:09     ` Russell King
2007-06-25 11:33       ` David Howells
2007-06-25 14:35         ` Kyle McMartin
2007-06-25 11:37       ` David Woodhouse
2007-06-25 11:47         ` Matthew Wilcox [this message]
2007-06-25 12:01           ` David Woodhouse
2007-06-25 12:04           ` Segher Boessenkool
2007-06-25 12:34             ` David Woodhouse
2007-06-25 13:10               ` Segher Boessenkool
2007-06-25 13:33                 ` David Woodhouse
2007-06-27 13:34           ` Ralf Baechle
2007-06-27 12:23         ` Geert Uytterhoeven
2007-06-27 13:22 ` Ralf Baechle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070625114742.GG22063@parisc-linux.org \
    --to=matthew@wil.cx \
    --cc=akpm@linux-foundation.org \
    --cc=drepper@redhat.com \
    --cc=dwmw2@infradead.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=paulus@samba.org \
    --cc=rmk@arm.linux.org.uk \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.