Re: Introduce fixed sys_sync_file_range2() syscall, implement on PowerPC and ARM

[Segher Boessenkool <segher@kernel.crashing.org>]

>> - Some architectures must align 64-bit integers into an aligned
>>   pair of registers. A slot may be wasted for padding.
>> - S390 may not have a 64-bit integer in slots 5/6.
>
> Uhm, doesn't sys_sync_file_range2 break that?
>
> +asmlinkage long compat_sys_sync_file_range2(int fd, unsigned int 
> flags,
> +                                  unsigned offset_hi, unsigned 
> offset_lo,
> +                                  unsigned nbytes_hi, unsigned 
> nbytes_lo)

I don't see any 64-bit integers here.

> Also, you might want to put something in the syscall file about signed
> vs unsigned arguments and how they behave with 32-on-64 systems.

"Both work / unsigned is better / use unsigned whenever
possible" -- but that's true for all C coding.  Wouldn't
hurt to repeat it though :-)


Segher