From: Arnd Bergmann <arnd@arndb.de>
To: "Zhang Wei-r63237" <Wei.Zhang@freescale.com>
Cc: linuxppc-dev@ozlabs.org, paulus@samba.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/5 v2] Add the platform device support with RapidIO to MPC8641HPCN platform.
Date: Thu, 28 Jun 2007 16:47:55 +0200 [thread overview]
Message-ID: <200706281647.57408.arnd@arndb.de> (raw)
In-Reply-To: <46B96294322F7D458F9648B60E15112C6F31B2@zch01exm26.fsl.freescale.net>
On Thursday 28 June 2007, Zhang Wei-r63237 wrote:
> > > +static __init int mpc86xx_of_device_init(void)
> > > +{
> > > +=A0=A0=A0=A0=A0=A0=A0return of_platform_bus_probe(NULL, mpc86xx_of_i=
ds, NULL);
> > > +}
> >=20
> > This will add any devices below the "fsl,rapidio-delta" device
> > as an of_device. Is that what you actually want? I would guess that
> > you want to add the bridge itself, not the devices below it.
> >=20
> > Is the rapidio device at the root of the device tree, and if so, why
> > not under the soc bus?
> >=20
>=20
> RapidIO is rather a bus that a device although these is no other nodes de=
fined in its sector now.
>=20
That's exactly my point. The meaning of of_platform_bus_probe() is 'add all
direct children of these nodes', not 'add these nodes', although it
happens to do that in the process.
Of course, looking at the device tree, rapidio is a device, not a bus,
because it does not have a device_type and it does not have any children
of its own.
Arnd <><
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: "Zhang Wei-r63237" <Wei.Zhang@freescale.com>
Cc: linuxppc-dev@ozlabs.org, mporter@kernel.crashing.org,
paulus@samba.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/5 v2] Add the platform device support with RapidIO to MPC8641HPCN platform.
Date: Thu, 28 Jun 2007 16:47:55 +0200 [thread overview]
Message-ID: <200706281647.57408.arnd@arndb.de> (raw)
In-Reply-To: <46B96294322F7D458F9648B60E15112C6F31B2@zch01exm26.fsl.freescale.net>
On Thursday 28 June 2007, Zhang Wei-r63237 wrote:
> > > +static __init int mpc86xx_of_device_init(void)
> > > +{
> > > + return of_platform_bus_probe(NULL, mpc86xx_of_ids, NULL);
> > > +}
> >
> > This will add any devices below the "fsl,rapidio-delta" device
> > as an of_device. Is that what you actually want? I would guess that
> > you want to add the bridge itself, not the devices below it.
> >
> > Is the rapidio device at the root of the device tree, and if so, why
> > not under the soc bus?
> >
>
> RapidIO is rather a bus that a device although these is no other nodes defined in its sector now.
>
That's exactly my point. The meaning of of_platform_bus_probe() is 'add all
direct children of these nodes', not 'add these nodes', although it
happens to do that in the process.
Of course, looking at the device tree, rapidio is a device, not a bus,
because it does not have a device_type and it does not have any children
of its own.
Arnd <><
next prev parent reply other threads:[~2007-06-28 14:49 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-27 8:35 [PATCH 0/5 v2] Porting RapidIO driver from ppc to powerpc architecture and adding memory mapped RapidIO driver Zhang Wei
2007-06-27 8:35 ` Zhang Wei
2007-06-27 8:35 ` [PATCH 1/5 v2] Add the explanation and a sample of RapidIO DTS sector to the document of booting-without-of.txt file Zhang Wei
2007-06-27 8:35 ` Zhang Wei
2007-06-27 8:35 ` [PATCH 2/5 v2] Add RapidIO sector to the MPC8641HPCN board dts file Zhang Wei
2007-06-27 8:35 ` Zhang Wei
2007-06-27 8:35 ` [PATCH 3/5 v2] Add the platform device support with RapidIO to MPC8641HPCN platform Zhang Wei
2007-06-27 8:35 ` Zhang Wei
2007-06-27 8:35 ` [PATCH 4/5 v2] Add RapidIO support to powerpc architecture Zhang Wei
2007-06-27 8:35 ` Zhang Wei
2007-06-27 8:35 ` [PATCH 5/5 v2] Add the memory management driver to RapidIO Zhang Wei
2007-06-27 8:35 ` Zhang Wei
2007-06-27 20:56 ` [PATCH 3/5 v2] Add the platform device support with RapidIO to MPC8641HPCN platform Arnd Bergmann
2007-06-27 20:56 ` Arnd Bergmann
2007-06-28 6:42 ` Zhang Wei-r63237
2007-06-28 6:42 ` Zhang Wei-r63237
2007-06-28 14:47 ` Arnd Bergmann [this message]
2007-06-28 14:47 ` Arnd Bergmann
2007-06-28 18:26 ` Segher Boessenkool
2007-06-28 18:26 ` Segher Boessenkool
2007-06-28 0:24 ` [PATCH 1/5 v2] Add the explanation and a sample of RapidIO DTS sector to the document of booting-without-of.txt file David Gibson
2007-06-28 0:24 ` David Gibson
2007-06-28 9:23 ` Segher Boessenkool
2007-06-28 9:23 ` Segher Boessenkool
2007-06-28 9:22 ` Segher Boessenkool
2007-06-28 9:22 ` Segher Boessenkool
2007-06-29 4:01 ` Zhang Wei-r63237
2007-06-29 4:01 ` Zhang Wei-r63237
2007-06-29 9:05 ` Segher Boessenkool
2007-06-29 9:05 ` Segher Boessenkool
2007-06-29 9:20 ` Zhang Wei-r63237
2007-06-29 9:20 ` Zhang Wei-r63237
2007-06-29 9:49 ` Segher Boessenkool
2007-06-29 9:49 ` Segher Boessenkool
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200706281647.57408.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=Wei.Zhang@freescale.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.