All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thiemo Seufer <ths@networkno.de>
To: Marion Hakanson <hakansom@ohsu.edu>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] patch vl.c, segfault with "qemu -h"
Date: Sat, 30 Jun 2007 00:27:09 +0100	[thread overview]
Message-ID: <20070629232709.GA644@networkno.de> (raw)
In-Reply-To: <200706291848.l5TImqXo021236@kyklops.ohsu.edu>

Marion Hakanson wrote:
> When you run "qemu -h", help() is called with optarg==NULL, which
> causes a segfault on my system (Solaris-10U3_x86, 64-bit kernel,
> but qemu compiled as 32-bit app, gcc-3.4.5 from blastwave.org).
> It's a side-effect of the -r1.315 patch which fixed related segfaults.
> 
> The following patch fixes the "-h" segfault, and also appears to yield
> the exit value intended by previous folks.

Thanks, I committed a fix which I hope is better.


Thiemo

  reply	other threads:[~2007-06-29 23:33 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-29 18:48 [Qemu-devel] patch vl.c, segfault with "qemu -h" Marion Hakanson
2007-06-29 23:27 ` Thiemo Seufer [this message]
2007-06-30  0:08   ` Marion Hakanson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070629232709.GA644@networkno.de \
    --to=ths@networkno.de \
    --cc=hakansom@ohsu.edu \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.