From: David Brownell <david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>
To: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
joakim.tjernlund-SNLAxHN9vbcOP4wsBPIw7w@public.gmane.org
Subject: Re: [PATCH] spi_mpc83xx.c, support QE enabled 83xx CPU's like mpc832x
Date: Sat, 30 Jun 2007 08:11:56 -0700 [thread overview]
Message-ID: <200706300811.56870.david-b@pacbell.net> (raw)
In-Reply-To: <1183215355.20673.106.camel-/EMGr9iCeazgSi9v3i4K4Pmbkio/vSLMs0AfqQuZ5sE@public.gmane.org>
On Saturday 30 June 2007, Joakim Tjernlund wrote:
> @@ -197,12 +203,22 @@ int mpc83xx_spi_setup_transfer(struct spi_device *spi, struct spi_transfer *t)
> || ((bits_per_word > 16) && (bits_per_word != 32)))
> return -EINVAL;
>
> + mpc83xx_spi->rx_shift = 0;
> + mpc83xx_spi->tx_shift = 0;
> if (bits_per_word <= 8) {
> mpc83xx_spi->get_rx = mpc83xx_spi_rx_buf_u8;
> mpc83xx_spi->get_tx = mpc83xx_spi_tx_buf_u8;
> + if (mpc83xx_spi->qe_mode) {
> + mpc83xx_spi->rx_shift = 16;
This shouldn't be "8" or "24"?
> + mpc83xx_spi->tx_shift = 24;
> + }
... I got the update with the missing header file.
-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
next prev parent reply other threads:[~2007-06-30 15:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-30 14:22 [PATCH] spi_mpc83xx.c, support QE enabled 83xx CPU's like mpc832x Joakim Tjernlund
[not found] ` <1183213370.20673.100.camel-/EMGr9iCeazgSi9v3i4K4Pmbkio/vSLMs0AfqQuZ5sE@public.gmane.org>
2007-06-30 14:55 ` Joakim Tjernlund
[not found] ` <1183215355.20673.106.camel-/EMGr9iCeazgSi9v3i4K4Pmbkio/vSLMs0AfqQuZ5sE@public.gmane.org>
2007-06-30 15:11 ` David Brownell [this message]
[not found] ` <200706300811.56870.david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>
2007-06-30 15:17 ` Joakim Tjernlund
2007-06-30 15:02 ` David Brownell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200706300811.56870.david-b@pacbell.net \
--to=david-b-ybekhbn/0ldr7s880joybq@public.gmane.org \
--cc=joakim.tjernlund-SNLAxHN9vbcOP4wsBPIw7w@public.gmane.org \
--cc=spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.