From: Stephen Hemminger <shemminger@linux-foundation.org>
To: Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@osdl.org>, Andi Kleen <ak@suse.de>
Cc: linux-kernel@vger.kernel.org
Subject: blink driver power saving
Date: Sun, 1 Jul 2007 12:50:35 -0400 [thread overview]
Message-ID: <20070701125035.3f54d8b0@oldman> (raw)
The blink driver wakes up every jiffies which wastes power unnecessarily.
Using a notifier gives same effect. Also add ability to unload module.
Signed-off-by: Stephen Hemminger <shemminger@linux-foundation.org>
--- a/drivers/misc/blink.c 2007-06-29 22:56:20.000000000 -0400
+++ b/drivers/misc/blink.c 2007-07-01 12:44:37.000000000 -0400
@@ -16,12 +16,30 @@ static void do_blink(unsigned long data)
add_timer(&blink_timer);
}
-static int blink_init(void)
+static int blink_panic_event(struct notifier_block *blk,
+ unsigned long event, void *arg)
{
- printk(KERN_INFO "Enabling keyboard blinking\n");
do_blink(0);
return 0;
}
+static struct notifier_block blink_notify = {
+ .notifier_call = blink_panic_event,
+};
+
+static __init int blink_init(void)
+{
+ printk(KERN_INFO "Enabling keyboard blinking\n");
+ atomic_notifier_chain_register(&panic_notifier_list, &blink_notify);
+ return 0;
+}
+
+static __exit void blink_remove(void)
+{
+ del_timer_sync(&blink_timer);
+ atomic_notifier_chain_unregister(&panic_notifier_list, &blink_notify);
+}
+
module_init(blink_init);
+module_exit(blink_remove);
next reply other threads:[~2007-07-01 16:50 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-01 16:50 Stephen Hemminger [this message]
2007-07-01 18:07 ` blink driver power saving Linus Torvalds
2007-07-01 21:29 ` Andi Kleen
2007-07-01 22:14 ` Linus Torvalds
2007-07-01 23:59 ` Andi Kleen
2007-07-02 15:51 ` Linus Torvalds
2007-07-02 16:59 ` Alan Cox
2007-07-02 17:50 ` Stephen Hemminger
2007-07-02 19:03 ` Dmitry Torokhov
2007-07-02 19:08 ` Andi Kleen
2007-07-02 23:18 ` Pavel Machek
2007-07-01 21:26 ` Andi Kleen
-- strict thread matches above, loose matches on Subject: below --
2007-07-02 11:43 Indan Zupancic
2007-07-02 11:51 ` Andi Kleen
2007-07-02 12:29 ` Indan Zupancic
2007-07-02 12:31 ` Dmitry Torokhov
2007-07-02 12:39 ` Andi Kleen
2007-07-02 12:56 ` Bernhard Walle
2007-07-02 13:42 ` Dmitry Torokhov
2007-07-02 13:43 ` Dmitry Torokhov
2007-07-02 20:19 ` Bernhard Walle
2007-07-04 21:47 ` Pavel Machek
2007-07-05 5:25 ` Dmitry Torokhov
2007-07-02 23:08 ` Pavel Machek
2007-07-03 5:42 ` Dmitry Torokhov
2007-07-04 21:40 ` Pavel Machek
2007-07-04 21:57 ` Pavel Machek
2007-07-04 22:11 ` Pavel Machek
2007-07-05 5:38 ` Dmitry Torokhov
2007-07-12 9:10 ` Pavel Machek
2007-07-13 0:42 ` Jiri Kosina
2007-07-04 22:32 ` Pavel Machek
2007-07-04 22:46 ` Linus Torvalds
2007-07-04 22:59 ` Pavel Machek
[not found] ` <alpine.LFD.0.98.0707041610530.9434@woody.linux-foundation.org>
2007-07-04 23:20 ` Pavel Machek
2007-07-03 7:12 ` Bernhard Walle
2007-07-04 19:37 ` Pavel Machek
2007-07-05 20:30 ` Bill Davidsen
[not found] <8CaWr-2o4-19@gated-at.bofh.it>
[not found] ` <8Cfjl-PJ-33@gated-at.bofh.it>
[not found] ` <8CfW1-1TX-23@gated-at.bofh.it>
[not found] ` <8ChEo-4yy-1@gated-at.bofh.it>
2007-07-02 13:11 ` Bodo Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070701125035.3f54d8b0@oldman \
--to=shemminger@linux-foundation.org \
--cc=ak@suse.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.