From: Al Viro <viro@ftp.linux.org.uk>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Ulrich Drepper <drepper@redhat.com>,
Markus Trippelsdorf <markus@trippelsdorf.de>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: 2.6.22-rc6(mm1) Unable to handle kernel NULL pointer dereference - git-bisect result
Date: Sun, 8 Jul 2007 19:51:18 +0100 [thread overview]
Message-ID: <20070708185118.GL21668@ftp.linux.org.uk> (raw)
In-Reply-To: <alpine.LFD.0.999.0707081130420.31544@woody.linux-foundation.org>
On Sun, Jul 08, 2007 at 11:38:20AM -0700, Linus Torvalds wrote:
> I do think that it would be even nicer to just have a function that fills
> in the "struct nameidata" from the dfd. I think we should be able to: the
> "struct file" really does have the "f_path" thing with both dentry and mnt
> information, and that would clean up that whole ugly "filepointer-vs-nd"
> thing a lot.
>
> That would be an "Al cleanup", though. What do you think, Al?
I think that we need to go the other way round - gather nameidata
->nd and ->dentry into struct path and pass pointer to that instead...
But that's .23-rc1 fodder, if not .23-rc2 one (we might want to
do -rc2 with just that, to avoid conflicts with pending patches).
Definitely not for .22-final.
next prev parent reply other threads:[~2007-07-08 18:51 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-08 5:14 2.6.22-rc6-mm1-cfs-v19 Unable to handle kernel NULL pointer dereference (reproducable) Markus Trippelsdorf
2007-07-08 8:20 ` Andrew Morton
2007-07-08 10:09 ` Markus Trippelsdorf
2007-07-08 15:28 ` 2.6.22-rc6(mm1) Unable to handle kernel NULL pointer dereference - git-bisect result Markus Trippelsdorf
2007-07-08 17:02 ` Linus Torvalds
2007-07-08 17:06 ` Ulrich Drepper
2007-07-08 17:33 ` Markus Trippelsdorf
2007-07-08 17:34 ` Al Viro
2007-07-08 17:41 ` Ulrich Drepper
2007-07-08 18:12 ` Linus Torvalds
2007-07-08 18:24 ` Ulrich Drepper
2007-07-08 18:31 ` Al Viro
2007-07-08 18:40 ` Linus Torvalds
2007-07-08 18:30 ` Linus Torvalds
2007-07-08 18:34 ` Al Viro
2007-07-08 18:38 ` Linus Torvalds
2007-07-08 18:51 ` Al Viro [this message]
2007-07-08 19:00 ` Linus Torvalds
2007-07-08 19:26 ` Al Viro
2007-07-08 18:19 ` Al Viro
2007-07-09 12:40 ` 2.6.22-rc6-mm1-cfs-v19 Unable to handle kernel NULL pointer dereference (reproducable) Lenar Lõhmus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070708185118.GL21668@ftp.linux.org.uk \
--to=viro@ftp.linux.org.uk \
--cc=akpm@linux-foundation.org \
--cc=drepper@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=markus@trippelsdorf.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.