From: Ulrich Drepper <drepper@redhat.com>
To: Al Viro <viro@ftp.linux.org.uk>
Cc: Markus Trippelsdorf <markus@trippelsdorf.de>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, torvalds@linux-foundation.org
Subject: Re: 2.6.22-rc6(mm1) Unable to handle kernel NULL pointer dereference - git-bisect result
Date: Sun, 08 Jul 2007 10:41:46 -0700 [thread overview]
Message-ID: <469121DA.6030600@redhat.com> (raw)
In-Reply-To: <20070708173416.GG21668@ftp.linux.org.uk>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Al Viro wrote:
> Like hell. At the very least you want it to be opened for write.
> And even that is dubious, since "process has write access to file"
> is not quite the same thing as "somebody had given the process a
> descriptor opened for write".
But the real permissions tests are performed in notify_change. I think
all this is consistent with how, for instance, fchmod works. The
additional tests in fchmod which aren't here (IS_RDONLY and IS_APPEND)
would also apply to the case where a file name is given. So, either the
code was inconsistent already are these tests are really not needed.
- --
➧ Ulrich Drepper ➧ Red Hat, Inc. ➧ 444 Castro St ➧ Mountain View, CA ❖
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (GNU/Linux)
iD8DBQFGkSHa2ijCOnn/RHQRAp0RAJ9ouvOd52feTPuFurxj8LzHZuGZsACgwxA8
ybEo1xmvakkKVenWc07PYhs=
=5DBy
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2007-07-08 17:42 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-08 5:14 2.6.22-rc6-mm1-cfs-v19 Unable to handle kernel NULL pointer dereference (reproducable) Markus Trippelsdorf
2007-07-08 8:20 ` Andrew Morton
2007-07-08 10:09 ` Markus Trippelsdorf
2007-07-08 15:28 ` 2.6.22-rc6(mm1) Unable to handle kernel NULL pointer dereference - git-bisect result Markus Trippelsdorf
2007-07-08 17:02 ` Linus Torvalds
2007-07-08 17:06 ` Ulrich Drepper
2007-07-08 17:33 ` Markus Trippelsdorf
2007-07-08 17:34 ` Al Viro
2007-07-08 17:41 ` Ulrich Drepper [this message]
2007-07-08 18:12 ` Linus Torvalds
2007-07-08 18:24 ` Ulrich Drepper
2007-07-08 18:31 ` Al Viro
2007-07-08 18:40 ` Linus Torvalds
2007-07-08 18:30 ` Linus Torvalds
2007-07-08 18:34 ` Al Viro
2007-07-08 18:38 ` Linus Torvalds
2007-07-08 18:51 ` Al Viro
2007-07-08 19:00 ` Linus Torvalds
2007-07-08 19:26 ` Al Viro
2007-07-08 18:19 ` Al Viro
2007-07-09 12:40 ` 2.6.22-rc6-mm1-cfs-v19 Unable to handle kernel NULL pointer dereference (reproducable) Lenar Lõhmus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=469121DA.6030600@redhat.com \
--to=drepper@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=markus@trippelsdorf.de \
--cc=torvalds@linux-foundation.org \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.