2.6.22 [PATCH 0/3] NLM: fix source address in server callbacks

2.6.22 [PATCH 0/3] NLM: fix source address in server callbacks

[Frank van Maarseveen]

Here's the patchset again but this time for 2.6.22 (verified) and based on
the earlier cleanup patch for creating a SUNRPC transport.  The xs_bind
(formerly xs_bindresvport) function slightly been recoded to make more
clear what it does.

The first patch changes the TCP server socket code to save the socket
name right after an accept(). This local address of a connection
(destination address of a request) is needed for connecting back when
doing the callback later. For UDP the address was already saved for RPC
replies because UDP is connectionless. This patch is IPv6 clean.

The second patch changes the NFS client code to be able to bind not only
to a privileged port but also to bind to a specific local address. The
client code is used by the server for callbacks.

The third patch is the actual NLM fix.

-- 
Frank

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs

Re: 2.6.22 [PATCH 0/3] NLM: fix source address in server callbacks

[Trond Myklebust]

On Mon, 2007-07-09 at 22:19 +0200, Frank van Maarseveen wrote:
> Here's the patchset again but this time for 2.6.22 (verified) and based on
> the earlier cleanup patch for creating a SUNRPC transport.  The xs_bind
> (formerly xs_bindresvport) function slightly been recoded to make more
> clear what it does.
> 
> The first patch changes the TCP server socket code to save the socket
> name right after an accept(). This local address of a connection
> (destination address of a request) is needed for connecting back when
> doing the callback later. For UDP the address was already saved for RPC
> replies because UDP is connectionless. This patch is IPv6 clean.
> 
> The second patch changes the NFS client code to be able to bind not only
> to a privileged port but also to bind to a specific local address. The
> client code is used by the server for callbacks.
> 
> The third patch is the actual NLM fix.

I've appended them to the NFS_ALL and the git tree. Unless Neil objects,
I propose that we just shove them in together with the existing NFS
merge.

Cheers
  Trond


-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs

Re: 2.6.22 [PATCH 0/3] NLM: fix source address in server callbacks

[Neil Brown]

On Monday July 9, trond.myklebust@fys.uio.no wrote:
> On Mon, 2007-07-09 at 22:19 +0200, Frank van Maarseveen wrote:
> > Here's the patchset again but this time for 2.6.22 (verified) and based on
> > the earlier cleanup patch for creating a SUNRPC transport.  The xs_bind
> > (formerly xs_bindresvport) function slightly been recoded to make more
> > clear what it does.
> > 
> > The first patch changes the TCP server socket code to save the socket
> > name right after an accept(). This local address of a connection
> > (destination address of a request) is needed for connecting back when
> > doing the callback later. For UDP the address was already saved for RPC
> > replies because UDP is connectionless. This patch is IPv6 clean.
> > 
> > The second patch changes the NFS client code to be able to bind not only
> > to a privileged port but also to bind to a specific local address. The
> > client code is used by the server for callbacks.
> > 
> > The third patch is the actual NLM fix.
> 
> I've appended them to the NFS_ALL and the git tree. Unless Neil objects,
> I propose that we just shove them in together with the existing NFS
> merge.

No objection from me - I support your proposal!

Thanks,
NeilBrown

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs