All of lore.kernel.org
 help / color / mirror / Atom feed
* - pie-randomization-fix-bad_addr-macro.patch removed from -mm tree
@ 2007-07-09 21:48 akpm
  0 siblings, 0 replies; only message in thread
From: akpm @ 2007-07-09 21:48 UTC (permalink / raw)
  To: jkosina, cebbert, jakub, riel, mm-commits


The patch titled
     pie randomization: fix BAD_ADDR macro
has been removed from the -mm tree.  Its filename was
     pie-randomization-fix-bad_addr-macro.patch

This patch was dropped because it was folded into pie-randomization.patch

------------------------------------------------------
Subject: pie randomization: fix BAD_ADDR macro
From: Jiri Kosina <jkosina@suse.cz>

pie-randomization.patch makes the load_addr in load_elf_interp() the load
bias of ld.so (difference between the actual load base address and first
PT_LOAD segment's p_vaddr).  If the difference equals (on x86) to
0xfffff000 (which is valid [1]), SIGSEGV is incorrectly sent.

This patch changes the BAD_ADDR so that it catches the mappings to the
error-area properly.

[1] https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=246623

Reported-by: Jakub Jelinek <jakub@redhat.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Cc: Chuck Ebbert <cebbert@redhat.com>
Cc: Rik van Riel <riel@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 fs/binfmt_elf.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

diff -puN fs/binfmt_elf.c~pie-randomization-fix-bad_addr-macro fs/binfmt_elf.c
--- a/fs/binfmt_elf.c~pie-randomization-fix-bad_addr-macro
+++ a/fs/binfmt_elf.c
@@ -80,7 +80,7 @@ static struct linux_binfmt elf_format = 
 		.hasvdso	= 1
 };
 
-#define BAD_ADDR(x) ((unsigned long)(x) >= PAGE_MASK)
+#define BAD_ADDR(x) IS_ERR_VALUE(x)
 
 static int set_brk(unsigned long start, unsigned long end)
 {
_

Patches currently in -mm which might be from jkosina@suse.cz are

git-hid.patch
git-ipwireless_cs.patch
x86_64-fix-wrong-comment-regarding-set_fixmap.patch
pie-randomization.patch
pie-randomization-fix-bad_addr-macro.patch
kernel-printkc-document-possible-deadlock-against-scheduler.patch
some-kmalloc-memset-kzalloc-tree-wide.patch
some-kmalloc-memset-kzalloc-tree-wide-kcalloc-fixes.patch

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2007-07-09 21:49 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-07-09 21:48 - pie-randomization-fix-bad_addr-macro.patch removed from -mm tree akpm

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.