* [PATCH] w1_ds2760: Fix binary file read callback signature
@ 2007-07-13 9:26 Jean Delvare
2007-07-13 9:38 ` Evgeniy Polyakov
0 siblings, 1 reply; 3+ messages in thread
From: Jean Delvare @ 2007-07-13 9:26 UTC (permalink / raw)
To: Evgeniy Polyakov; +Cc: LKML, Zhang Rui
Commit 91a6902958f052358899f58683d44e36228d85c2 changed the binary
sysfs file signatures at the same time the w1_ds2760 driver was added.
Signed-off-by: Jean Delvare <khali@linux-fr.org>
---
drivers/w1/slaves/w1_ds2760.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
--- linux-2.6.23-pre.orig/drivers/w1/slaves/w1_ds2760.c 2007-07-13 09:46:35.000000000 +0200
+++ linux-2.6.23-pre/drivers/w1/slaves/w1_ds2760.c 2007-07-13 11:11:38.000000000 +0200
@@ -68,8 +68,9 @@ int w1_ds2760_write(struct device *dev,
return w1_ds2760_io(dev, buf, addr, count, 1);
}
-static ssize_t w1_ds2760_read_bin(struct kobject *kobj, char *buf, loff_t off,
- size_t count)
+static ssize_t w1_ds2760_read_bin(struct kobject *kobj,
+ struct bin_attribute *bin_attr,
+ char *buf, loff_t off, size_t count)
{
struct device *dev = container_of(kobj, struct device, kobj);
return w1_ds2760_read(dev, buf, off, count);
--
Jean Delvare
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] w1_ds2760: Fix binary file read callback signature
2007-07-13 9:26 [PATCH] w1_ds2760: Fix binary file read callback signature Jean Delvare
@ 2007-07-13 9:38 ` Evgeniy Polyakov
2007-07-13 9:47 ` Jean Delvare
0 siblings, 1 reply; 3+ messages in thread
From: Evgeniy Polyakov @ 2007-07-13 9:38 UTC (permalink / raw)
To: Jean Delvare; +Cc: LKML, Zhang Rui
On Fri, Jul 13, 2007 at 11:26:43AM +0200, Jean Delvare (khali@linux-fr.org) wrote:
> Commit 91a6902958f052358899f58683d44e36228d85c2 changed the binary
> sysfs file signatures at the same time the w1_ds2760 driver was added.
>
> Signed-off-by: Jean Delvare <khali@linux-fr.org>
I have no problem with this patch. Should I forward it to Andrew or you
will pick this up?
Acked-by: Evgeniy Polyakov <johnpol@2ka.mipt.ru>
--
Evgeniy Polyakov
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] w1_ds2760: Fix binary file read callback signature
2007-07-13 9:38 ` Evgeniy Polyakov
@ 2007-07-13 9:47 ` Jean Delvare
0 siblings, 0 replies; 3+ messages in thread
From: Jean Delvare @ 2007-07-13 9:47 UTC (permalink / raw)
To: Evgeniy Polyakov; +Cc: LKML, Zhang Rui
Hi Evgeniy,
On Fri, 13 Jul 2007 13:38:51 +0400, Evgeniy Polyakov wrote:
> On Fri, Jul 13, 2007 at 11:26:43AM +0200, Jean Delvare (khali@linux-fr.org) wrote:
> > Commit 91a6902958f052358899f58683d44e36228d85c2 changed the binary
> > sysfs file signatures at the same time the w1_ds2760 driver was added.
> >
> > Signed-off-by: Jean Delvare <khali@linux-fr.org>
>
> I have no problem with this patch. Should I forward it to Andrew or you
> will pick this up?
Please forward it to Andrew.
Thanks,
--
Jean Delvare
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-07-13 9:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-07-13 9:26 [PATCH] w1_ds2760: Fix binary file read callback signature Jean Delvare
2007-07-13 9:38 ` Evgeniy Polyakov
2007-07-13 9:47 ` Jean Delvare
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.