From: Arnd Bergmann <arnd@arndb.de>
To: cbe-oss-dev@ozlabs.org
Cc: James Simmons <jsimmons@infradead.org>,
"Antonino A. Daplas" <adaplas@gmail.com>,
linux-kernel@vger.kernel.org,
Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>,
linux-fbdev-devel@lists.sourceforge.net,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [Cbe-oss-dev] [patch 0/4] Cell SPE logos
Date: Fri, 13 Jul 2007 12:05:19 +0200 [thread overview]
Message-ID: <200707131205.20399.arnd@arndb.de> (raw)
In-Reply-To: <Pine.LNX.4.62.0707131051190.18802@pademelon.sonytel.be>
On Friday 13 July 2007, Geert Uytterhoeven wrote:
> > > Summaries:
> > > [1] fbdev: extract fb_show_logo_line()
> > > [2] fbdev: Add fb_append_extra_logo()
> >
> > This one does give additional code and data to all fbdev users while only
> > being useful to cell machines. Should we fix that?
>
> I can protect it by #ifdef CONFIG_PPC_CELL (as long as there are no other
> users). Would that be OK?
If you want to have an #ifdef in there, it should probably be
CONFIG_FB_EXTRA_LOGO and have that autoselected by CONFIG_SPU_BASE.
A nicer alternative to the #ifdef might be to mark it __init, so
that it will just go away after boot. Not sure if that's safe
though.
Arnd <><
-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: cbe-oss-dev@ozlabs.org
Cc: Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-fbdev-devel@lists.sourceforge.net,
"Antonino A. Daplas" <adaplas@gmail.com>,
linux-kernel@vger.kernel.org,
James Simmons <jsimmons@infradead.org>
Subject: Re: [Cbe-oss-dev] [patch 0/4] Cell SPE logos
Date: Fri, 13 Jul 2007 12:05:19 +0200 [thread overview]
Message-ID: <200707131205.20399.arnd@arndb.de> (raw)
In-Reply-To: <Pine.LNX.4.62.0707131051190.18802@pademelon.sonytel.be>
On Friday 13 July 2007, Geert Uytterhoeven wrote:
> > > Summaries:
> > > [1] fbdev: extract fb_show_logo_line()
> > > [2] fbdev: Add fb_append_extra_logo()
> >
> > This one does give additional code and data to all fbdev users while only
> > being useful to cell machines. Should we fix that?
>
> I can protect it by #ifdef CONFIG_PPC_CELL (as long as there are no other
> users). Would that be OK?
If you want to have an #ifdef in there, it should probably be
CONFIG_FB_EXTRA_LOGO and have that autoselected by CONFIG_SPU_BASE.
A nicer alternative to the #ifdef might be to mark it __init, so
that it will just go away after boot. Not sure if that's safe
though.
Arnd <><
next prev parent reply other threads:[~2007-07-13 10:07 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-10 12:27 [patch 0/4] Cell SPE logos Geert Uytterhoeven
2007-07-10 12:27 ` [patch 1/4] fbdev: extract fb_show_logo_line() Geert Uytterhoeven
2007-07-10 12:27 ` Geert Uytterhoeven
2007-07-10 12:27 ` [patch 2/4] fbdev: Add fb_append_extra_logo() Geert Uytterhoeven
2007-07-10 12:27 ` Geert Uytterhoeven
2007-07-13 0:15 ` Antonino A. Daplas
2007-07-13 0:15 ` Antonino A. Daplas
2007-07-13 6:56 ` Geert Uytterhoeven
2007-07-13 6:56 ` Geert Uytterhoeven
2007-07-13 11:45 ` Antonino A. Daplas
2007-07-13 11:45 ` Antonino A. Daplas
2007-07-13 12:02 ` Geert Uytterhoeven
2007-07-13 12:02 ` Geert Uytterhoeven
2007-07-13 6:58 ` Geert Uytterhoeven
2007-07-13 6:58 ` Geert Uytterhoeven
2007-07-13 11:53 ` Antonino A. Daplas
2007-07-13 11:53 ` Antonino A. Daplas
2007-07-10 12:27 ` [patch 3/4] fbdev: SPE helper penguin logo Geert Uytterhoeven
2007-07-10 12:27 ` Geert Uytterhoeven
2007-07-10 12:27 ` [patch 4/4] Cell: Draw SPE helper penguin logos Geert Uytterhoeven
2007-07-10 12:27 ` Geert Uytterhoeven
2007-07-10 16:54 ` [Cbe-oss-dev] " Arnd Bergmann
2007-07-10 16:54 ` Arnd Bergmann
2007-07-12 23:06 ` [patch 0/4] Cell SPE logos Andrew Morton
2007-07-13 8:52 ` Geert Uytterhoeven
2007-07-13 8:52 ` Geert Uytterhoeven
2007-07-13 9:06 ` Andrew Morton
2007-07-13 9:09 ` Geert Uytterhoeven
2007-07-13 9:09 ` Geert Uytterhoeven
2007-07-13 12:30 ` Benjamin Herrenschmidt
2007-07-13 12:30 ` [Linux-fbdev-devel] " Benjamin Herrenschmidt
2007-07-13 10:05 ` Arnd Bergmann [this message]
2007-07-13 10:05 ` [Cbe-oss-dev] " Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200707131205.20399.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=Geert.Uytterhoeven@sonycom.com \
--cc=adaplas@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=cbe-oss-dev@ozlabs.org \
--cc=jsimmons@infradead.org \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.