From: Al Viro <viro@ftp.linux.org.uk>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linuxppc-dev@ozlabs.org, torvalds@linux-foundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] the wrong variable checked after request_irq()
Date: Sun, 15 Jul 2007 23:02:16 +0100 [thread overview]
Message-ID: <20070715220216.GF21668@ftp.linux.org.uk> (raw)
In-Reply-To: <1184535638.25235.15.camel@localhost.localdomain>
On Mon, Jul 16, 2007 at 07:40:38AM +1000, Benjamin Herrenschmidt wrote:
> On Sun, 2007-07-15 at 20:59 +0100, Al Viro wrote:
> > Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
>
> Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
>
> Out of curiosity, how did you pick it up ? You have some automated tool
> to catch that (or sparse changes) or you just did -lots- of code
> inspection ?
While testing sparse changes, actually (comparing pointers to null
pointer constant spelled without a cast to void *)... That gave several
hundred hits, most of them being immediately obvious (picking the lines
by file and line number and looking through the list had eliminated all
but about a dozen or two). Several were not...
WARNING: multiple messages have this Message-ID (diff)
From: Al Viro <viro@ftp.linux.org.uk>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: torvalds@linux-foundation.org, linuxppc-dev@ozlabs.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] the wrong variable checked after request_irq()
Date: Sun, 15 Jul 2007 23:02:16 +0100 [thread overview]
Message-ID: <20070715220216.GF21668@ftp.linux.org.uk> (raw)
In-Reply-To: <1184535638.25235.15.camel@localhost.localdomain>
On Mon, Jul 16, 2007 at 07:40:38AM +1000, Benjamin Herrenschmidt wrote:
> On Sun, 2007-07-15 at 20:59 +0100, Al Viro wrote:
> > Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
>
> Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
>
> Out of curiosity, how did you pick it up ? You have some automated tool
> to catch that (or sparse changes) or you just did -lots- of code
> inspection ?
While testing sparse changes, actually (comparing pointers to null
pointer constant spelled without a cast to void *)... That gave several
hundred hits, most of them being immediately obvious (picking the lines
by file and line number and looking through the list had eliminated all
but about a dozen or two). Several were not...
next prev parent reply other threads:[~2007-07-15 22:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-15 19:59 [PATCH] the wrong variable checked after request_irq() Al Viro
2007-07-15 19:59 ` Al Viro
2007-07-15 21:40 ` Benjamin Herrenschmidt
2007-07-15 21:40 ` Benjamin Herrenschmidt
2007-07-15 22:02 ` Al Viro [this message]
2007-07-15 22:02 ` Al Viro
2007-07-15 22:07 ` Benjamin Herrenschmidt
2007-07-15 22:07 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070715220216.GF21668@ftp.linux.org.uk \
--to=viro@ftp.linux.org.uk \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.