[PATCH] change pci_find_device to pci_get_device,

[PATCH] change pci_find_device to pci_get_device,

[Denis Cheng]

this eliminates compiler warning:

drivers/scsi/advansys.c: In function ‘advansys_detect’:
drivers/scsi/advansys.c:4456: warning: ‘pci_find_device’ is deprecated (declared at include/linux/pci.h:478)

Signed-off-by: Denis Cheng <crquan@gmail.com>
---
 drivers/scsi/advansys.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/scsi/advansys.c b/drivers/scsi/advansys.c
index 2b66897..8e5abd1 100644
--- a/drivers/scsi/advansys.c
+++ b/drivers/scsi/advansys.c
@@ -4453,7 +4453,7 @@ advansys_detect(struct scsi_host_template *tpnt)
 
                     /* Find all PCI cards. */
                     while (pci_device_id_cnt < ASC_PCI_DEVICE_ID_CNT) {
-                        if ((pci_devp = pci_find_device(PCI_VENDOR_ID_ASP,
+                        if ((pci_devp = pci_get_device(PCI_VENDOR_ID_ASP,
                             pci_device_id[pci_device_id_cnt], pci_devp)) ==
                             NULL) {
                             pci_device_id_cnt++;
-- 
1.5.2.2

Re: [PATCH] change pci_find_device to pci_get_device,

[rae l]

On 7/16/07, Denis Cheng <crquan@gmail.com> wrote:
> this eliminates compiler warning:
>
> drivers/scsi/advansys.c: In function 'advansys_detect':
> drivers/scsi/advansys.c:4456: warning: 'pci_find_device' is deprecated (declared at include/linux/pci.h:478)
But there is still one warning left:
drivers/scsi/advansys.c:794:2: warning: #warning this driver is still
not properly converted to the DMA API

>
> Signed-off-by: Denis Cheng <crquan@gmail.com>
> ---
>  drivers/scsi/advansys.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/scsi/advansys.c b/drivers/scsi/advansys.c
> index 2b66897..8e5abd1 100644
> --- a/drivers/scsi/advansys.c
> +++ b/drivers/scsi/advansys.c
> @@ -4453,7 +4453,7 @@ advansys_detect(struct scsi_host_template *tpnt)
>
>                      /* Find all PCI cards. */
>                      while (pci_device_id_cnt < ASC_PCI_DEVICE_ID_CNT) {
> -                        if ((pci_devp = pci_find_device(PCI_VENDOR_ID_ASP,
> +                        if ((pci_devp = pci_get_device(PCI_VENDOR_ID_ASP,
>                              pci_device_id[pci_device_id_cnt], pci_devp)) =
>                              NULL) {
>                              pci_device_id_cnt++;
> --
> 1.5.2.2
>
>


-- 
Denis Cheng
Linux Application Developer

"One of my most productive days was throwing away 1000 lines of code."
 - Ken Thompson.

Re: [PATCH] change pci_find_device to pci_get_device,

[Matthew Wilcox]

On Mon, Jul 16, 2007 at 03:02:39PM +0800, Denis Cheng wrote:
> @@ -4453,7 +4453,7 @@ advansys_detect(struct scsi_host_template *tpnt)
>  
>                      /* Find all PCI cards. */
>                      while (pci_device_id_cnt < ASC_PCI_DEVICE_ID_CNT) {
> -                        if ((pci_devp = pci_find_device(PCI_VENDOR_ID_ASP,
> +                        if ((pci_devp = pci_get_device(PCI_VENDOR_ID_ASP,
>                              pci_device_id[pci_device_id_cnt], pci_devp)) =
>                              NULL) {
>                              pci_device_id_cnt++;
> -- 

Where do you drop the reference to the PCI device again?

-- 
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."

Re: [PATCH] change pci_find_device to pci_get_device,

[rae l]

On 7/16/07, Matthew Wilcox <matthew@wil.cx> wrote:
> On Mon, Jul 16, 2007 at 03:02:39PM +0800, Denis Cheng wrote:
> > @@ -4453,7 +4453,7 @@ advansys_detect(struct scsi_host_template *tpnt)
> >
> >                      /* Find all PCI cards. */
> >                      while (pci_device_id_cnt < ASC_PCI_DEVICE_ID_CNT) {
> > -                        if ((pci_devp = pci_find_device(PCI_VENDOR_ID_ASP,
> > +                        if ((pci_devp = pci_get_device(PCI_VENDOR_ID_ASP,
> >                              pci_device_id[pci_device_id_cnt], pci_devp)) =
> >                              NULL) {
> >                              pci_device_id_cnt++;
> > --
>
> Where do you drop the reference to the PCI device again?
I don't know how to solve this problem, I just want to do some kernel
janitors project to contribute to the linux kernel, I'm just a kernel
newbie;
Because the pci_find_device is deprecated, the comments in this
function said, please use pci_get_device instead; but pci_get_device
called here return a (struct pci_dev *) to a local variable, someone
could tell me when to call pci_put_device?

Thanks.

>
> --
> "Bill, look, we understand that you're interested in selling us this
> operating system, but compare it to ours.  We can't possibly take such
> a retrograde step."
>


-- 
Denis Cheng
Linux Application Developer

"One of my most productive days was throwing away 1000 lines of code."
 - Ken Thompson.

Re: [PATCH] change pci_find_device to pci_get_device,

[Matthew Wilcox]

On Mon, Jul 16, 2007 at 10:53:33PM +0800, rae l wrote:
> I don't know how to solve this problem, I just want to do some kernel
> janitors project to contribute to the linux kernel, I'm just a kernel
> newbie;

Pick an easier project; this one is too intricate.

> Because the pci_find_device is deprecated, the comments in this
> function said, please use pci_get_device instead; but pci_get_device
> called here return a (struct pci_dev *) to a local variable, someone
> could tell me when to call pci_put_device?

The correct way to do this is to convert the driver to use the
pci_register_driver API.  I'm taking a stab at it now -- and let me
assure you that it's not easy.

-- 
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."

Re: [PATCH] change pci_find_device to pci_get_device,

[Greg KH]

On Mon, Jul 16, 2007 at 10:53:33PM +0800, rae l wrote:
>  On 7/16/07, Matthew Wilcox <matthew@wil.cx> wrote:
> > On Mon, Jul 16, 2007 at 03:02:39PM +0800, Denis Cheng wrote:
> > > @@ -4453,7 +4453,7 @@ advansys_detect(struct scsi_host_template *tpnt)
> > >
> > >                      /* Find all PCI cards. */
> > >                      while (pci_device_id_cnt < ASC_PCI_DEVICE_ID_CNT) {
> > > -                        if ((pci_devp = 
> > pci_find_device(PCI_VENDOR_ID_ASP,
> > > +                        if ((pci_devp = 
> > pci_get_device(PCI_VENDOR_ID_ASP,
> > >                              pci_device_id[pci_device_id_cnt], pci_devp)) 
> > =
> > >                              NULL) {
> > >                              pci_device_id_cnt++;
> > > --
> >
> > Where do you drop the reference to the PCI device again?
>  I don't know how to solve this problem, I just want to do some kernel
>  janitors project to contribute to the linux kernel, I'm just a kernel
>  newbie;
>  Because the pci_find_device is deprecated, the comments in this
>  function said, please use pci_get_device instead; but pci_get_device
>  called here return a (struct pci_dev *) to a local variable, someone
>  could tell me when to call pci_put_device?

Please read the comments for the pci_get_device() function to fully
understand why people have not just gone through and done a simple
search-and-replace action for the whole kernel tree.  It is much more
complex than that.

good luck,

greg k-h

Re: [PATCH] change pci_find_device to pci_get_device,

[Matthew Wilcox]

On Mon, Jul 16, 2007 at 05:09:47PM -0700, Greg KH wrote:
> Please read the comments for the pci_get_device() function to fully
> understand why people have not just gone through and done a simple
> search-and-replace action for the whole kernel tree.  It is much more
> complex than that.

Yes, it is.  Here's my solution:

http://marc.info/?l=linux-scsi&m\x118462846525015&w=2
http://marc.info/?l=linux-scsi&m\x118462738926857&w=2
http://marc.info/?l=linux-scsi&m\x118463215810772&w=2
http://marc.info/?l=linux-scsi&m\x118462771422817&w=2

Untested, as I don't have the hardware.

-- 
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."