From: David Miller <davem@davemloft.net>
To: cornelia.huck@de.ibm.com
Cc: kaber@trash.net, netfilter-devel@lists.netfilter.org,
linux-netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
jengelh@linux01.gwdg.de
Subject: Re: [PATCH] netfilter: xt_connlimit needs to depend on nf_conntrack
Date: Wed, 18 Jul 2007 02:39:23 -0700 (PDT) [thread overview]
Message-ID: <20070718.023923.124552237.davem@davemloft.net> (raw)
In-Reply-To: <20070716125352.3525ec5b@gondolin.boeblingen.de.ibm.com>
From: Cornelia Huck <cornelia.huck@de.ibm.com>
Date: Mon, 16 Jul 2007 12:53:52 +0200
> Subject: [PATCH] netfilter: xt_connlimit needs to depend on nf_conntrack
> From: Cornelia Huck <cornelia.huck@de.ibm.com>
> To: <linux-netdev@vger.kernel.org>
> Cc: <linux-kernel@vger.kernel.org>, netfilter-devel@lists.netfilter.org,
> "David S. Miller" <davem@davemloft.net>,
> Jan Engelhardt <jengelh@linux01.gwdg.de>,
> Patrick McHardy <kaber@trash.net>
> Date: Mon, 16 Jul 2007 12:53:52 +0200
> X-Mailer: Claws Mail 2.10.0 (GTK+ 2.10.13; i486-pc-linux-gnu)
> Organization: IBM Deutschland Entwicklung GmbH
>
> With NF_CONNTRACK=n, NETFILTER_XT_MATCH_CONNLIMIT=m I get the
> following errors on current git:
>
> CC [M] net/netfilter/xt_connlimit.o
> In file included from net/netfilter/xt_connlimit.c:27:
> include/net/netfilter/nf_conntrack.h:100: error: field 'ct_general' has incomplete type
> include/net/netfilter/nf_conntrack.h: In function 'nf_ct_get':
> include/net/netfilter/nf_conntrack.h:164: error: 'const struct sk_buff' has no member named 'nfct'
> include/net/netfilter/nf_conntrack.h: In function 'nf_ct_put':
> include/net/netfilter/nf_conntrack.h:171: warning: implicit declaration of function 'nf_conntrack_put'
> include/net/netfilter/nf_conntrack.h: In function 'nf_ct_is_untracked':
> include/net/netfilter/nf_conntrack.h:253: error: 'const struct sk_buff' has no member named 'nfct'
> In file included from net/netfilter/xt_connlimit.c:28:
> include/net/netfilter/nf_conntrack_core.h: In function 'nf_conntrack_confirm':
> include/net/netfilter/nf_conntrack_core.h:68: error: 'struct sk_buff' has no member named 'nfct'
>
> Adding a dependency in Kconfig fixes this.
>
> Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
Applied, thanks.
WARNING: multiple messages have this Message-ID (diff)
From: David Miller <davem@davemloft.net>
To: cornelia.huck@de.ibm.com
Cc: linux-netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
netfilter-devel@lists.netfilter.org, jengelh@linux01.gwdg.de,
kaber@trash.net
Subject: Re: [PATCH] netfilter: xt_connlimit needs to depend on nf_conntrack
Date: Wed, 18 Jul 2007 02:39:23 -0700 (PDT) [thread overview]
Message-ID: <20070718.023923.124552237.davem@davemloft.net> (raw)
In-Reply-To: <20070716125352.3525ec5b@gondolin.boeblingen.de.ibm.com>
From: Cornelia Huck <cornelia.huck@de.ibm.com>
Date: Mon, 16 Jul 2007 12:53:52 +0200
> Subject: [PATCH] netfilter: xt_connlimit needs to depend on nf_conntrack
> From: Cornelia Huck <cornelia.huck@de.ibm.com>
> To: <linux-netdev@vger.kernel.org>
> Cc: <linux-kernel@vger.kernel.org>, netfilter-devel@lists.netfilter.org,
> "David S. Miller" <davem@davemloft.net>,
> Jan Engelhardt <jengelh@linux01.gwdg.de>,
> Patrick McHardy <kaber@trash.net>
> Date: Mon, 16 Jul 2007 12:53:52 +0200
> X-Mailer: Claws Mail 2.10.0 (GTK+ 2.10.13; i486-pc-linux-gnu)
> Organization: IBM Deutschland Entwicklung GmbH
>
> With NF_CONNTRACK=n, NETFILTER_XT_MATCH_CONNLIMIT=m I get the
> following errors on current git:
>
> CC [M] net/netfilter/xt_connlimit.o
> In file included from net/netfilter/xt_connlimit.c:27:
> include/net/netfilter/nf_conntrack.h:100: error: field 'ct_general' has incomplete type
> include/net/netfilter/nf_conntrack.h: In function 'nf_ct_get':
> include/net/netfilter/nf_conntrack.h:164: error: 'const struct sk_buff' has no member named 'nfct'
> include/net/netfilter/nf_conntrack.h: In function 'nf_ct_put':
> include/net/netfilter/nf_conntrack.h:171: warning: implicit declaration of function 'nf_conntrack_put'
> include/net/netfilter/nf_conntrack.h: In function 'nf_ct_is_untracked':
> include/net/netfilter/nf_conntrack.h:253: error: 'const struct sk_buff' has no member named 'nfct'
> In file included from net/netfilter/xt_connlimit.c:28:
> include/net/netfilter/nf_conntrack_core.h: In function 'nf_conntrack_confirm':
> include/net/netfilter/nf_conntrack_core.h:68: error: 'struct sk_buff' has no member named 'nfct'
>
> Adding a dependency in Kconfig fixes this.
>
> Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
Applied, thanks.
next prev parent reply other threads:[~2007-07-18 9:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-16 10:53 [PATCH] netfilter: xt_connlimit needs to depend on nf_conntrack Cornelia Huck
2007-07-17 15:07 ` Patrick McHardy
2007-07-18 9:39 ` David Miller [this message]
2007-07-18 9:39 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070718.023923.124552237.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=cornelia.huck@de.ibm.com \
--cc=jengelh@linux01.gwdg.de \
--cc=kaber@trash.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-netdev@vger.kernel.org \
--cc=netfilter-devel@lists.netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.