Fwd: [patch 075/134] i386: During VM oom condition, kill all threads in process group

Fwd: [patch 075/134] i386: During VM oom condition, kill all threads in process group

[Andi Kleen]

[-- Attachment #1: Type: text/plain, Size: 81 bytes --]


FYI

You might want to check if your architecture needs this change too.

-Andi

[-- Attachment #2: akpm@linux-foundation.org: [patch 075/134] i386: During VM oom condition, kill all threads in process group --]
[-- Type: message/rfc822, Size: 3517 bytes --]

From: akpm@linux-foundation.org
To: ak@suse.de
Cc: akpm@linux-foundation.org, will_schmidt@vnet.ibm.com
Subject: [patch 075/134] i386: During VM oom condition, kill all threads in process group
Date: Mon, 09 Jul 2007 12:48:19 -0700
Message-ID: <200707091948.l69JmJXr005727@imap1.linux-foundation.org>

From: Will Schmidt <will_schmidt@vnet.ibm.com>

During a VM oom condition, kill all threads in the process group.

We have had complaints where a threaded application is left in a bad state
after one of it's threads is killed when we hit a VM: out_of_memory condition.

Killing just one of the process threads can leave the application in a bad
state, whereas killing the entire process group would allow for the
application to restart, or otherwise handled, and makes it very obvious that
something has gone wrong.

This change allows the entire process group to be taken down, rather than just
the one thread.

tested lightly on i386.

Signed-off-by: Will Schmidt <will_schmidt@vnet.ibm.com>
Cc: Andi Kleen <ak@suse.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 arch/i386/mm/fault.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

diff -puN arch/i386/mm/fault.c~i386-during-vm-oom-condition arch/i386/mm/fault.c
--- a/arch/i386/mm/fault.c~i386-during-vm-oom-condition
+++ a/arch/i386/mm/fault.c
@@ -598,7 +598,7 @@ out_of_memory:
 	}
 	printk("VM: killing process %s\n", tsk->comm);
 	if (error_code & 4)
-		do_exit(SIGKILL);
+		do_group_exit(SIGKILL);
 	goto no_context;
 
 do_sigbus:
_