From: Andi Kleen <ak@muc.de>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: Zachary Amsden <zach@vmware.com>,
lkml - Kernel Mailing List <linux-kernel@vger.kernel.org>,
kvm-devel <kvm-devel@lists.sourceforge.net>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 2/3] i386: use x86_64's desc_def.h
Date: 19 Jul 2007 02:00:26 +0200
Date: Thu, 19 Jul 2007 02:00:26 +0200 [thread overview]
Message-ID: <20070719000026.GA29650@muc.de> (raw)
In-Reply-To: <1184801261.10380.174.camel@localhost.localdomain>
On Thu, Jul 19, 2007 at 09:27:41AM +1000, Rusty Russell wrote:
> On Wed, 2007-07-18 at 09:19 -0700, Zachary Amsden wrote:
> > > +#define GET_CONTENTS(desc) (((desc)->raw32.b >> 10) & 3)
> > > +#define GET_WRITABLE(desc) (((desc)->raw32.b >> 9) & 1)
> >
> > You got rid of the duplicate definitions here, but then added new
> > duplicates (GET_CONTENTS / WRITABLE). Can you stick them in desc.h?
>
> To be honest, I got sick of counting bits at this point, and didn't want
> to introduce bugs.
Where is 1/ and 3/ ?
I got an older version of this patch queued now
-Andi
WARNING: multiple messages have this Message-ID (diff)
From: Andi Kleen <ak-h9bWGtP8wOw@public.gmane.org>
To: Rusty Russell <rusty-8n+1lVoiYb80n/F98K4Iww@public.gmane.org>
Cc: Zachary Amsden <zach-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org>,
kvm-devel
<kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>,
Andrew Morton
<akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>,
lkml - Kernel Mailing List
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH 2/3] i386: use x86_64's desc_def.h
Date: 19 Jul 2007 02:00:26 +0200
Date: Thu, 19 Jul 2007 02:00:26 +0200 [thread overview]
Message-ID: <20070719000026.GA29650@muc.de> (raw)
In-Reply-To: <1184801261.10380.174.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
On Thu, Jul 19, 2007 at 09:27:41AM +1000, Rusty Russell wrote:
> On Wed, 2007-07-18 at 09:19 -0700, Zachary Amsden wrote:
> > > +#define GET_CONTENTS(desc) (((desc)->raw32.b >> 10) & 3)
> > > +#define GET_WRITABLE(desc) (((desc)->raw32.b >> 9) & 1)
> >
> > You got rid of the duplicate definitions here, but then added new
> > duplicates (GET_CONTENTS / WRITABLE). Can you stick them in desc.h?
>
> To be honest, I got sick of counting bits at this point, and didn't want
> to introduce bugs.
Where is 1/ and 3/ ?
I got an older version of this patch queued now
-Andi
-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
next prev parent reply other threads:[~2007-07-19 0:00 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-18 7:22 [PATCH 1/3] Standardize x86_64's desc_defs.h in preparation for exposure to i386 Rusty Russell
2007-07-18 7:22 ` Rusty Russell
2007-07-18 7:23 ` [PATCH 2/3] i386: use x86_64's desc_def.h Rusty Russell
2007-07-18 7:23 ` Rusty Russell
2007-07-18 7:30 ` [PATCH 3/3] i386: Replace struct Xgt_desc_struct with struct desc_ptr Rusty Russell
2007-07-18 7:30 ` Rusty Russell
2007-07-21 1:33 ` Chris Wright
2007-07-21 1:33 ` Chris Wright
2007-07-18 16:19 ` [PATCH 2/3] i386: use x86_64's desc_def.h Zachary Amsden
2007-07-18 23:27 ` Rusty Russell
2007-07-18 23:27 ` Rusty Russell
2007-07-18 23:29 ` Rusty Russell
2007-07-18 23:29 ` Rusty Russell
2007-07-21 1:32 ` Chris Wright
2007-07-21 1:32 ` Chris Wright
2007-07-19 0:00 ` Andi Kleen [this message]
2007-07-19 0:00 ` Andi Kleen
2007-07-18 9:03 ` [PATCH 1/3] Standardize x86_64's desc_defs.h in preparation for exposure to i386 Andi Kleen
2007-07-18 9:03 ` Andi Kleen
2007-07-18 11:44 ` Rusty Russell
2007-07-18 11:44 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070719000026.GA29650@muc.de \
--to=ak@muc.de \
--cc=akpm@linux-foundation.org \
--cc=kvm-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=zach@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.