* [patch 2.6.22] Do not include other cpus' interrupt 0 in nmi_watchdog
@ 2007-07-19 7:01 Keith Owens
2007-07-19 8:23 ` Andi Kleen
0 siblings, 1 reply; 2+ messages in thread
From: Keith Owens @ 2007-07-19 7:01 UTC (permalink / raw)
To: Thomas Gleixner; +Cc: linux-arch
kstat_irqs(0) includes the count of interrupt 0 from all cpus, not just
the current cpu. The updated interrupt 0 on other cpus can stop the
nmi_watchdog from tripping, so only include the current cpu's int 0.
Signed-off-by: Keith Owens <kaos@ocs.com.au>
---
arch/i386/kernel/nmi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux/arch/i386/kernel/nmi.c
===================================================================
--- linux.orig/arch/i386/kernel/nmi.c
+++ linux/arch/i386/kernel/nmi.c
@@ -351,7 +351,7 @@ __kprobes int nmi_watchdog_tick(struct p
* Take the local apic timer and PIT/HPET into account. We don't
* know which one is active, when we have highres/dyntick on
*/
- sum = per_cpu(irq_stat, cpu).apic_timer_irqs + kstat_irqs(0);
+ sum = per_cpu(irq_stat, cpu).apic_timer_irqs + kstat_cpu(cpu).irqs[0];
/* if the none of the timers isn't firing, this cpu isn't doing much */
if (!touched && last_irq_sums[cpu] == sum) {
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [patch 2.6.22] Do not include other cpus' interrupt 0 in nmi_watchdog
2007-07-19 7:01 [patch 2.6.22] Do not include other cpus' interrupt 0 in nmi_watchdog Keith Owens
@ 2007-07-19 8:23 ` Andi Kleen
0 siblings, 0 replies; 2+ messages in thread
From: Andi Kleen @ 2007-07-19 8:23 UTC (permalink / raw)
To: Keith Owens; +Cc: Thomas Gleixner, linux-arch
On Thursday 19 July 2007 09:01:26 Keith Owens wrote:
> kstat_irqs(0) includes the count of interrupt 0 from all cpus, not just
> the current cpu. The updated interrupt 0 on other cpus can stop the
> nmi_watchdog from tripping, so only include the current cpu's int 0.
I queued the patch thanks.
-Andi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-07-19 8:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-07-19 7:01 [patch 2.6.22] Do not include other cpus' interrupt 0 in nmi_watchdog Keith Owens
2007-07-19 8:23 ` Andi Kleen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.