From: Srivatsa Vaddagiri <vatsa@linux.vnet.ibm.com>
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: Jan Glauber <jang@linux.vnet.ibm.com>,
LKML <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@elte.hu>,
mschwid2@linux.vnet.ibm.com, efault@gmx.de,
dmitry.adamushko@gmail.com, paulus@samba.org, anton@samba.org
Subject: Re: [PATCH] virtual sched_clock() for s390
Date: Thu, 19 Jul 2007 21:18:20 +0530 [thread overview]
Message-ID: <20070719154820.GM2216@linux.vnet.ibm.com> (raw)
In-Reply-To: <469F8342.7060000@goop.org>
On Thu, Jul 19, 2007 at 08:29:06AM -0700, Jeremy Fitzhardinge wrote:
> > - * Monotonic_clock - returns # of nanoseconds passed since time_init()
> > + * Scheduler clock - returns current time in nanosec units.
> > + * Now based on virtual cpu time to only account time the guest
> > + * was actually running.
> >
>
> Runn*ing*? Does it include time the VCPU spends idle/blocked? If not,
> then the scheduler won't be able to tell how long a process has been
> asleep.
Good point ..
I think we need a measure of both virtual and real time here -
virtual for accounting task-execution time and real for
accounting sleep (and perhaps rq-wait?) time.
> Maybe this doesn't matter (I had this problem in a version of
> Xen's sched_clock, and I can't say I saw an ill effects from it).
I guess it will show up as some corner case behaviour, which people are
yet to discover on virtual env.
--
Regards,
vatsa
next prev parent reply other threads:[~2007-07-19 15:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-19 10:57 [PATCH] virtual sched_clock() for s390 Jan Glauber
2007-07-19 15:29 ` Jeremy Fitzhardinge
2007-07-19 15:48 ` Srivatsa Vaddagiri [this message]
2007-07-19 16:00 ` Ingo Molnar
2007-07-19 19:20 ` Jan Glauber
2007-07-19 19:38 ` Ingo Molnar
2007-07-19 21:07 ` Jan Glauber
2007-07-20 1:01 ` Paul Mackerras
2007-07-20 6:03 ` Jeremy Fitzhardinge
2007-07-20 7:22 ` Ingo Molnar
2007-07-23 9:15 ` Jan Glauber
2007-07-23 13:24 ` Martin Schwidefsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070719154820.GM2216@linux.vnet.ibm.com \
--to=vatsa@linux.vnet.ibm.com \
--cc=anton@samba.org \
--cc=dmitry.adamushko@gmail.com \
--cc=efault@gmx.de \
--cc=jang@linux.vnet.ibm.com \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mschwid2@linux.vnet.ibm.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.