From: "John W. Linville" <linville@tuxdriver.com>
To: Daniel Drake <dsd@gentoo.org>
Cc: jbenc@suse.cz, netdev@vger.kernel.org,
linux-wireless@vger.kernel.org,
rt2400-devel@lists.sourceforge.net, mb@bu3sch.de,
flamingice@sourmilk.net
Subject: Re: [PATCH v2 1/2] mac80211: improved short preamble handling
Date: Thu, 19 Jul 2007 15:15:13 -0400 [thread overview]
Message-ID: <20070719191513.GD6603@tuxdriver.com> (raw)
In-Reply-To: <20070715140739.C13187B409F@zog.reactivated.net>
On Sun, Jul 15, 2007 at 03:07:39PM +0100, Daniel Drake wrote:
> Similarly to CTS protection, whether short preambles are used for 802.11b
> transmissions should be a per-subif setting, not device global.
>
> For STAs, this patch makes short preamble handling automatic based on the ERP
> IE. For APs, hostapd still uses the prism ioctls, but the write ioctl has been
> restricted to AP-only subifs.
>
> ieee80211_txrx_data.short_preamble (an unused field) was removed.
>
> Unfortunately, some API changes were required for the following functions:
> - ieee80211_generic_frame_duration
> - ieee80211_rts_duration
> - ieee80211_ctstoself_duration
> - ieee80211_rts_get
> - ieee80211_ctstoself_get
> Affected drivers (bcm43xx, rt2x00 and rtl8187) were updated accordingly.
>
> Signed-off-by: Daniel Drake <dsd@gentoo.org>
Jiri, Michael -- this applies to upstream w/ just some offsets if you
ignore the driver bits that aren't upstream. I'll be happy to handle
the patch monkeying if you are happy w/ this patch.
John
--
John W. Linville
linville@tuxdriver.com
WARNING: multiple messages have this Message-ID (diff)
From: "John W. Linville" <linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
To: Daniel Drake <dsd-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org>
Cc: jbenc-AlSwsSmVLrQ@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
rt2400-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
mb-fseUSCV1ubazQB+pC5nmwQ@public.gmane.org,
flamingice-R9e9/4HEdknk1uMJSBkQmQ@public.gmane.org
Subject: Re: [PATCH v2 1/2] mac80211: improved short preamble handling
Date: Thu, 19 Jul 2007 15:15:13 -0400 [thread overview]
Message-ID: <20070719191513.GD6603@tuxdriver.com> (raw)
In-Reply-To: <20070715140739.C13187B409F-k/4jFdqg8LLlyo9zxV8I99HuzzzSOjJt@public.gmane.org>
On Sun, Jul 15, 2007 at 03:07:39PM +0100, Daniel Drake wrote:
> Similarly to CTS protection, whether short preambles are used for 802.11b
> transmissions should be a per-subif setting, not device global.
>
> For STAs, this patch makes short preamble handling automatic based on the ERP
> IE. For APs, hostapd still uses the prism ioctls, but the write ioctl has been
> restricted to AP-only subifs.
>
> ieee80211_txrx_data.short_preamble (an unused field) was removed.
>
> Unfortunately, some API changes were required for the following functions:
> - ieee80211_generic_frame_duration
> - ieee80211_rts_duration
> - ieee80211_ctstoself_duration
> - ieee80211_rts_get
> - ieee80211_ctstoself_get
> Affected drivers (bcm43xx, rt2x00 and rtl8187) were updated accordingly.
>
> Signed-off-by: Daniel Drake <dsd-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org>
Jiri, Michael -- this applies to upstream w/ just some offsets if you
ignore the driver bits that aren't upstream. I'll be happy to handle
the patch monkeying if you are happy w/ this patch.
John
--
John W. Linville
linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org
next prev parent reply other threads:[~2007-07-19 19:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-15 14:07 [PATCH v2 1/2] mac80211: improved short preamble handling Daniel Drake
2007-07-19 19:15 ` John W. Linville [this message]
2007-07-19 19:15 ` John W. Linville
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070719191513.GD6603@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=dsd@gentoo.org \
--cc=flamingice@sourmilk.net \
--cc=jbenc@suse.cz \
--cc=linux-wireless@vger.kernel.org \
--cc=mb@bu3sch.de \
--cc=netdev@vger.kernel.org \
--cc=rt2400-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.