All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Wilcox <matthew@wil.cx>
To: Simon Arlott <simon@fire.lp0.eu>
Cc: Denis Cheng <crquan@gmail.com>,
	kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] run scripts/Lindent on it to match Documentation/CodingStyle
Date: Fri, 20 Jul 2007 17:07:43 +0000	[thread overview]
Message-ID: <20070720170743.GF14791@parisc-linux.org> (raw)
In-Reply-To: <4699EEA9.6070709@simon.arlott.org.uk>

On Sun, Jul 15, 2007 at 10:53:45AM +0100, Simon Arlott wrote:
> Do people ever check what Lindent does?
[...]
> > -out1:
> > +      out1:
> 
> NAK: A perfectly valid non-indented label is now indented by 6 spaces.

I tracked down why indent does this.  It's actually hard-coded to indent
by 2 fewer columns than the current code indentation.  I've patched it
to allow specifying either an absolute column, or a column relative to
the current indentation level.

Patch here:
http://bugs.debian.org/cgi-bin/bugreport.cgi?bugC3956

Of course, we can't add this flag to Lindent until it's widely
circulating amongst the distributions.  Perhaps we can add this to
Lindent in the meantime:

sed -i -e 's/^\t*      \(\w*:\)/ \1/' "$@"

which will replace the leading tabs and spaces with one space.
It should leave case labels unmolested, as they should be indented with
tabs, not 6 spaces.

Any regexp ninjas want to have a go at something better?

-- 
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."

WARNING: multiple messages have this Message-ID (diff)
From: Matthew Wilcox <matthew@wil.cx>
To: Simon Arlott <simon@fire.lp0.eu>
Cc: Denis Cheng <crquan@gmail.com>,
	kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] run scripts/Lindent on it to match Documentation/CodingStyle
Date: Fri, 20 Jul 2007 11:07:43 -0600	[thread overview]
Message-ID: <20070720170743.GF14791@parisc-linux.org> (raw)
In-Reply-To: <4699EEA9.6070709@simon.arlott.org.uk>

On Sun, Jul 15, 2007 at 10:53:45AM +0100, Simon Arlott wrote:
> Do people ever check what Lindent does?
[...]
> > -out1:
> > +      out1:
> 
> NAK: A perfectly valid non-indented label is now indented by 6 spaces.

I tracked down why indent does this.  It's actually hard-coded to indent
by 2 fewer columns than the current code indentation.  I've patched it
to allow specifying either an absolute column, or a column relative to
the current indentation level.

Patch here:
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=433956

Of course, we can't add this flag to Lindent until it's widely
circulating amongst the distributions.  Perhaps we can add this to
Lindent in the meantime:

sed -i -e 's/^\t*      \(\w*:\)/ \1/' "$@"

which will replace the leading tabs and spaces with one space.
It should leave case labels unmolested, as they should be indented with
tabs, not 6 spaces.

Any regexp ninjas want to have a go at something better?

-- 
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."

  reply	other threads:[~2007-07-20 17:07 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-15  8:52 [PATCH 1/2] run scripts/Lindent on it to match Documentation/CodingStyle Denis Cheng
2007-07-15  8:52 ` Denis Cheng
2007-07-15  8:52 ` [PATCH 2/2] add static delaration and init_module fixes Denis Cheng
2007-07-15  8:52   ` Denis Cheng
2007-07-15  9:20 ` [PATCH 1/2] run scripts/Lindent on it to match Documentation/CodingStyle Christoph Hellwig
2007-07-15  9:20   ` Christoph Hellwig
2007-07-15  9:53 ` Simon Arlott
2007-07-15  9:53   ` Simon Arlott
2007-07-20 17:07   ` Matthew Wilcox [this message]
2007-07-20 17:07     ` Matthew Wilcox
2007-07-20 17:36     ` Simon Arlott
2007-07-20 17:36       ` Simon Arlott
2007-07-20 18:00       ` Matthew Wilcox
2007-07-20 18:00         ` Matthew Wilcox
2007-07-21  6:11         ` Simon Arlott
2007-07-21  6:11           ` Simon Arlott
2007-07-21 13:47           ` rae l
2007-07-21 13:47             ` rae l
2007-07-21 13:52           ` Matthew Wilcox
2007-07-21 13:52             ` Matthew Wilcox
2007-07-21 19:17             ` diffutils: C labels misdetected as functions (Was: [PATCH 1/2] run Simon Arlott
2007-07-21 19:17               ` diffutils: C labels misdetected as functions (Was: [PATCH 1/2] run scripts/Lindent on it to match Documentation/CodingStyle) Simon Arlott
2007-07-22 18:38               ` diffutils: C labels misdetected as functions Paul Eggert
2007-07-22 18:38                 ` Paul Eggert
2007-07-22 19:16                 ` Simon Arlott
2007-07-22 19:16                   ` Simon Arlott
2007-07-22 21:30                   ` Junio C Hamano
2007-07-22 21:30                     ` Junio C Hamano
2007-07-21  6:12         ` [PATCH 1/2] run scripts/Lindent on it to match Documentation/CodingStyle Simon Arlott
2007-07-21  6:12           ` Simon Arlott
2007-07-20 20:50     ` Oleg Verych
2007-07-20 20:50       ` Oleg Verych
2007-07-20 20:54       ` Matthew Wilcox
2007-07-20 20:54         ` Matthew Wilcox
2007-07-21  4:32         ` Fixing lables after GNU indent (Re: [PATCH 1/2] run scripts/Lindent on it to match Documentation/Cod Oleg Verych
2007-07-21  4:32           ` Fixing lables after GNU indent (Re: [PATCH 1/2] run scripts/Lindent on it to match Documentation/CodingStyle) Oleg Verych
2007-07-21 16:17     ` [PATCH 1/2] run scripts/Lindent on it to match Documentation/CodingStyle Jan Engelhardt
2007-07-21 16:17       ` Jan Engelhardt
2007-07-20 17:33   ` Matthew Wilcox
2007-07-20 17:33     ` Matthew Wilcox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070720170743.GF14791@parisc-linux.org \
    --to=matthew@wil.cx \
    --cc=crquan@gmail.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=simon@fire.lp0.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.