From: Andi Kleen <andi@firstfloor.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Andi Kleen <andi@firstfloor.org>,
Fengguang Wu <wfg@mail.ustc.edu.cn>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/8] compacting file_ra_state
Date: Sat, 21 Jul 2007 08:17:20 +0200 [thread overview]
Message-ID: <20070721061720.GA5293@one.firstfloor.org> (raw)
In-Reply-To: <alpine.LFD.0.999.0707202312260.27249@woody.linux-foundation.org>
On Fri, Jul 20, 2007 at 11:13:34PM -0700, Linus Torvalds wrote:
> > I thought the new patches were some some restructured code, but
> > essentially the tested algorithms?
>
> No, this series is a further cleanup on top of the restructured code, with
> some new features too. The series _looks_ fine to me, but it still makes
> sense to go through -mm, I think.
What I meant was:
iirc he first had a "very complex" patchkit in -mm* (the one
with multiple predictors working together); then that got then replaced
with a simpler easier to review one and now he's feeding the stuff from
the complex one piece by piece back.
Just pointed out that the newer stuff was likely already in -mm* for some
time, just before one of the simplifications.
But I guess more testing cannot hurt anyways.
Anyways it's good we're finally making forward progress on this. It has
the potential for real nice performance gains.
-Andi
next prev parent reply other threads:[~2007-07-21 6:17 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-21 3:57 [PATCH 0/8] readahead cleanups and interleaved readahead take 2 Fengguang Wu
2007-07-21 3:57 ` Fengguang Wu
2007-07-21 3:57 ` [PATCH 1/8] compacting file_ra_state Fengguang Wu
2007-07-21 3:57 ` Fengguang Wu
2007-07-21 4:06 ` Fengguang Wu
2007-07-21 4:06 ` Fengguang Wu
2007-07-21 4:27 ` Linus Torvalds
2007-07-21 4:29 ` Fengguang Wu
2007-07-21 4:29 ` Fengguang Wu
2007-07-21 5:57 ` Andi Kleen
2007-07-21 6:03 ` Andrew Morton
2007-07-21 6:13 ` Linus Torvalds
2007-07-21 6:17 ` Andi Kleen [this message]
2007-07-21 3:57 ` [PATCH 2/8] mmap read-around simplification Fengguang Wu
2007-07-21 3:57 ` Fengguang Wu
2007-07-21 3:57 ` [PATCH 3/8] combine file_ra_state.prev_index/prev_offset into prev_pos Fengguang Wu
2007-07-21 3:57 ` Fengguang Wu
2007-07-21 3:57 ` [PATCH 4/8] trivial filemap.c cleanups Fengguang Wu
2007-07-21 3:57 ` Fengguang Wu
2007-07-21 3:57 ` [PATCH 5/8] remove several readahead macros Fengguang Wu
2007-07-21 3:57 ` Fengguang Wu
2007-07-21 3:57 ` [PATCH 6/8] remove the limit max_sectors_kb imposed on max_readahead_kb Fengguang Wu
2007-07-21 3:57 ` Fengguang Wu
2007-07-21 3:57 ` [PATCH 7/8] introduce radix_tree_scan_hole() Fengguang Wu
2007-07-21 3:57 ` Fengguang Wu
2007-07-21 3:57 ` [PATCH 8/8] basic support of interleaved reads Fengguang Wu
2007-07-21 3:57 ` Fengguang Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070721061720.GA5293@one.firstfloor.org \
--to=andi@firstfloor.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=wfg@mail.ustc.edu.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.