All of lore.kernel.org
 help / color / mirror / Atom feed
From: Fengguang Wu <wfg@mail.ustc.edu.cn>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Andrew Morton <akpm@osdl.org>,
	linux-kernel@vger.kernel.org, Andi Kleen <andi@firstfloor.org>
Subject: [PATCH 1/8] compacting file_ra_state
Date: Sat, 21 Jul 2007 11:57:34 +0800	[thread overview]
Message-ID: <384990324.22217@ustc.edu.cn> (raw)
Message-ID: <20070721035850.977231489@mail.ustc.edu.cn> (raw)
In-Reply-To: 20070721035733.951838089@mail.ustc.edu.cn

[-- Attachment #1: short-rasize.patch --]
[-- Type: text/plain, Size: 1624 bytes --]

Use 'unsigned int' instead of 'unsigned long' for readahead sizes.

This helps reduce memory consumption on 64bit CPU when
a lot of files are opened.

CC: Andi Kleen <andi@firstfloor.org>
Signed-off-by: Fengguang Wu <wfg@mail.ustc.edu.cn>
---
 include/linux/fs.h |    8 ++++----
 mm/readahead.c     |    2 +-
 2 files changed, 5 insertions(+), 5 deletions(-)

--- linux-2.6.22-git15.orig/include/linux/fs.h
+++ linux-2.6.22-git15/include/linux/fs.h
@@ -697,12 +697,12 @@ struct fown_struct {
  * Track a single file's readahead state
  */
 struct file_ra_state {
-	pgoff_t start;                  /* where readahead started */
-	unsigned long size;             /* # of readahead pages */
-	unsigned long async_size;       /* do asynchronous readahead when
+	pgoff_t start;			/* where readahead started */
+	unsigned int size;		/* # of readahead pages */
+	unsigned int async_size;	/* do asynchronous readahead when
 					   there are only # of pages ahead */
 
-	unsigned long ra_pages;		/* Maximum readahead window */
+	unsigned int ra_pages;		/* Maximum readahead window */
 	unsigned long mmap_hit;		/* Cache hit stat for mmap accesses */
 	unsigned long mmap_miss;	/* Cache miss stat for mmap accesses */
 	unsigned long prev_index;	/* Cache last read() position */
--- linux-2.6.22-git15.orig/mm/readahead.c
+++ linux-2.6.22-git15/mm/readahead.c
@@ -350,7 +350,7 @@ ondemand_readahead(struct address_space 
 		   bool hit_readahead_marker, pgoff_t offset,
 		   unsigned long req_size)
 {
-	unsigned long max;	/* max readahead pages */
+	int max;	/* max readahead pages */
 	int sequential;
 
 	max = ra->ra_pages;

--

  parent reply	other threads:[~2007-07-21  3:59 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-21  3:57 [PATCH 0/8] readahead cleanups and interleaved readahead take 2 Fengguang Wu
2007-07-21  3:57 ` Fengguang Wu
2007-07-21  3:57 ` Fengguang Wu [this message]
2007-07-21  3:57   ` [PATCH 1/8] compacting file_ra_state Fengguang Wu
2007-07-21  4:06   ` Fengguang Wu
2007-07-21  4:06     ` Fengguang Wu
2007-07-21  4:27       ` Linus Torvalds
2007-07-21  4:29         ` Fengguang Wu
2007-07-21  4:29           ` Fengguang Wu
2007-07-21  5:57         ` Andi Kleen
2007-07-21  6:03           ` Andrew Morton
2007-07-21  6:13           ` Linus Torvalds
2007-07-21  6:17             ` Andi Kleen
2007-07-21  3:57 ` [PATCH 2/8] mmap read-around simplification Fengguang Wu
2007-07-21  3:57   ` Fengguang Wu
2007-07-21  3:57 ` [PATCH 3/8] combine file_ra_state.prev_index/prev_offset into prev_pos Fengguang Wu
2007-07-21  3:57   ` Fengguang Wu
2007-07-21  3:57 ` [PATCH 4/8] trivial filemap.c cleanups Fengguang Wu
2007-07-21  3:57   ` Fengguang Wu
2007-07-21  3:57 ` [PATCH 5/8] remove several readahead macros Fengguang Wu
2007-07-21  3:57   ` Fengguang Wu
2007-07-21  3:57 ` [PATCH 6/8] remove the limit max_sectors_kb imposed on max_readahead_kb Fengguang Wu
2007-07-21  3:57   ` Fengguang Wu
2007-07-21  3:57 ` [PATCH 7/8] introduce radix_tree_scan_hole() Fengguang Wu
2007-07-21  3:57   ` Fengguang Wu
2007-07-21  3:57 ` [PATCH 8/8] basic support of interleaved reads Fengguang Wu
2007-07-21  3:57   ` Fengguang Wu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=384990324.22217@ustc.edu.cn \
    --to=wfg@mail.ustc.edu.cn \
    --cc=akpm@osdl.org \
    --cc=andi@firstfloor.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.