From: Dmitry Torokhov <dtor@insightbb.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Adrian Bunk <bunk@stusta.de>,
Andrew Morton <akpm@linux-foundation.org>,
linux-m68k@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-input@atrey.karlin.mff.cuni.cz, linuxppc-dev@ozlabs.org
Subject: Re: [patch 1/3] m68k/mac: Make mac_hid_mouse_emulate_buttons() declaration visible
Date: Sun, 22 Jul 2007 00:22:40 -0400 [thread overview]
Message-ID: <200707220022.41797.dtor@insightbb.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0707211026070.18493@anakin>
Hi Geert,
On Saturday 21 July 2007 04:27, Geert Uytterhoeven wrote:
> On Fri, 20 Jul 2007, Dmitry Torokhov wrote:
> >
> > I am OK with adding a new header file. I was just saying that placing
> > that declaration in linux/hid.h makes about the same sense as putting
> > it into linux/scsi.h
>
> At first I just wanted to move it. Then I thought about the angry
> comments I would get about not moving it to a header file ;-)
>
> <linux/hid.h> looked like the best candidate. <linux/kbd_kern.h> is
> another option.
>
linux/kbd_kern.h sounds much better.
--
Dmitry
WARNING: multiple messages have this Message-ID (diff)
From: Dmitry Torokhov <dtor@insightbb.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: linux-m68k@vger.kernel.org, linux-kernel@vger.kernel.org,
Adrian Bunk <bunk@stusta.de>,
linuxppc-dev@ozlabs.org, linux-input@atrey.karlin.mff.cuni.cz,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [patch 1/3] m68k/mac: Make mac_hid_mouse_emulate_buttons() declaration visible
Date: Sun, 22 Jul 2007 00:22:40 -0400 [thread overview]
Message-ID: <200707220022.41797.dtor@insightbb.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0707211026070.18493@anakin>
Hi Geert,
On Saturday 21 July 2007 04:27, Geert Uytterhoeven wrote:
> On Fri, 20 Jul 2007, Dmitry Torokhov wrote:
> >
> > I am OK with adding a new header file. I was just saying that placing
> > that declaration in linux/hid.h makes about the same sense as putting
> > it into linux/scsi.h
>
> At first I just wanted to move it. Then I thought about the angry
> comments I would get about not moving it to a header file ;-)
>
> <linux/hid.h> looked like the best candidate. <linux/kbd_kern.h> is
> another option.
>
linux/kbd_kern.h sounds much better.
--
Dmitry
next prev parent reply other threads:[~2007-07-22 4:22 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-20 16:40 [patch 0/3] m68k: -Werror-implicit-function-declaration fallout Geert Uytterhoeven
2007-07-20 16:40 ` [patch 1/3] m68k/mac: Make mac_hid_mouse_emulate_buttons() declaration visible Geert Uytterhoeven
2007-07-20 16:40 ` Geert Uytterhoeven
2007-07-20 17:47 ` Dmitry Torokhov
2007-07-20 17:47 ` Dmitry Torokhov
2007-07-20 18:35 ` Adrian Bunk
2007-07-20 18:35 ` Adrian Bunk
2007-07-20 18:51 ` Dmitry Torokhov
2007-07-20 18:51 ` Dmitry Torokhov
2007-07-20 19:07 ` Adrian Bunk
2007-07-20 19:07 ` Adrian Bunk
2007-07-20 19:30 ` Dmitry Torokhov
2007-07-20 19:30 ` Dmitry Torokhov
2007-07-21 8:27 ` Geert Uytterhoeven
2007-07-21 8:27 ` Geert Uytterhoeven
2007-07-22 4:22 ` Dmitry Torokhov [this message]
2007-07-22 4:22 ` Dmitry Torokhov
2007-07-22 12:51 ` Geert Uytterhoeven
2007-07-22 12:51 ` Geert Uytterhoeven
2007-07-24 0:45 ` Dmitry Torokhov
2007-07-24 0:45 ` Dmitry Torokhov
2007-07-20 16:40 ` [patch 2/3] netdev: i82596 Ethernet needs <asm/cacheflush.h> Geert Uytterhoeven
2007-07-24 20:37 ` Jeff Garzik
2007-07-20 16:40 ` [patch 3/3] scsi: wd33c93 needs <asm/irq.h> Geert Uytterhoeven
2007-07-20 16:48 ` James Bottomley
2007-07-20 17:05 ` Geert Uytterhoeven
2007-07-20 17:13 ` Adrian Bunk
2007-07-20 17:31 ` Ralf Baechle
2007-07-20 17:33 ` Christoph Hellwig
2007-07-20 17:43 ` Sergei Shtylyov
2007-07-20 17:50 ` Matthew Wilcox
2007-07-22 23:34 ` Al Viro
2007-07-20 17:46 ` Ralf Baechle
2007-07-20 17:34 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200707220022.41797.dtor@insightbb.com \
--to=dtor@insightbb.com \
--cc=akpm@linux-foundation.org \
--cc=bunk@stusta.de \
--cc=geert@linux-m68k.org \
--cc=linux-input@atrey.karlin.mff.cuni.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.