From: Al Viro <viro@ftp.linux.org.uk>
To: David Miller <davem@davemloft.net>
Cc: linux-kernel@vger.kernel.org, sparclinux@vger.kernel.org,
sam@ravnborg.org
Subject: Re: [RFC] Kconfig fun with sparc32/sparc64 rtc drivers
Date: Sun, 22 Jul 2007 06:31:49 +0000 [thread overview]
Message-ID: <20070722063149.GQ21668@ftp.linux.org.uk> (raw)
In-Reply-To: <20070721.232207.26531557.davem@davemloft.net>
On Sat, Jul 21, 2007 at 11:22:07PM -0700, David Miller wrote:
> From: Al Viro <viro@ftp.linux.org.uk>
> Date: Sun, 22 Jul 2007 07:19:24 +0100
>
> > We probably ought to make drivers/sbus/char/rtc.c sparc32-only,
> > then - AFAICS it simply won't be able to register misc device and that
> > will be it. ACK?
>
> ACK.
>
> > > 2) all the __sparc_v9__ crap is removed from drivers/char/rtc.c
> > > 3) all the __sparc__ crap is changed to CONFIG_SPARC32 in same
> > > 4) CONFIG_RTC is not longer allows on sparc64, only sparc32 with PCI
> >
> > Umm... OK, that takes care of sparc64 side of things, which is probably
> > all we realistically care about. Except that it still leaves broken sparc32
> > defconfig - we have RTC=m, SUN_MOSTEK_RTC=m and kbuild won't deal with it...
>
> That definitely needs to be fixed and I'm willing to entertain
> any suggestion on how to deal with it.
Crude and simple way would be to add
config JS_RTC
tristate "JavaStation RTC"
depends on SPARC32 && PCI
<copy help from RTC with s/will be called rtc/will be called js-rtc>
in drivers/char/Kconfig, slap plain and simple !SPARC in RTC dependencies
and put
js-rtc-y = rtc.o
obj-$(JS_RTC) += js-rtc.o
in drivers/char/Makefile
Objections?
WARNING: multiple messages have this Message-ID (diff)
From: Al Viro <viro@ftp.linux.org.uk>
To: David Miller <davem@davemloft.net>
Cc: linux-kernel@vger.kernel.org, sparclinux@vger.kernel.org,
sam@ravnborg.org
Subject: Re: [RFC] Kconfig fun with sparc32/sparc64 rtc drivers
Date: Sun, 22 Jul 2007 07:31:49 +0100 [thread overview]
Message-ID: <20070722063149.GQ21668@ftp.linux.org.uk> (raw)
In-Reply-To: <20070721.232207.26531557.davem@davemloft.net>
On Sat, Jul 21, 2007 at 11:22:07PM -0700, David Miller wrote:
> From: Al Viro <viro@ftp.linux.org.uk>
> Date: Sun, 22 Jul 2007 07:19:24 +0100
>
> > We probably ought to make drivers/sbus/char/rtc.c sparc32-only,
> > then - AFAICS it simply won't be able to register misc device and that
> > will be it. ACK?
>
> ACK.
>
> > > 2) all the __sparc_v9__ crap is removed from drivers/char/rtc.c
> > > 3) all the __sparc__ crap is changed to CONFIG_SPARC32 in same
> > > 4) CONFIG_RTC is not longer allows on sparc64, only sparc32 with PCI
> >
> > Umm... OK, that takes care of sparc64 side of things, which is probably
> > all we realistically care about. Except that it still leaves broken sparc32
> > defconfig - we have RTC=m, SUN_MOSTEK_RTC=m and kbuild won't deal with it...
>
> That definitely needs to be fixed and I'm willing to entertain
> any suggestion on how to deal with it.
Crude and simple way would be to add
config JS_RTC
tristate "JavaStation RTC"
depends on SPARC32 && PCI
<copy help from RTC with s/will be called rtc/will be called js-rtc>
in drivers/char/Kconfig, slap plain and simple !SPARC in RTC dependencies
and put
js-rtc-y = rtc.o
obj-$(JS_RTC) += js-rtc.o
in drivers/char/Makefile
Objections?
next prev parent reply other threads:[~2007-07-22 6:31 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-20 13:24 sparc64: ERROR: "sys_ioctl" [arch/sparc64/solaris/solaris.ko] undefined! Horst H. von Brand
2007-07-20 13:24 ` Horst H. von Brand
2007-07-20 16:11 ` Christoph Hellwig
2007-07-20 16:11 ` Christoph Hellwig
2007-07-22 2:22 ` sparc64: ERROR: "sys_ioctl" [arch/sparc64/solaris/solaris.ko] David Miller
2007-07-22 2:22 ` sparc64: ERROR: "sys_ioctl" [arch/sparc64/solaris/solaris.ko] undefined! David Miller
2007-07-22 5:43 ` [RFC] Kconfig fun with sparc32/sparc64 rtc drivers Al Viro
2007-07-22 5:43 ` Al Viro
2007-07-22 5:54 ` David Miller
2007-07-22 5:54 ` David Miller
2007-07-22 6:19 ` Al Viro
2007-07-22 6:19 ` Al Viro
2007-07-22 6:22 ` David Miller
2007-07-22 6:22 ` David Miller
2007-07-22 6:31 ` Al Viro [this message]
2007-07-22 6:31 ` Al Viro
2007-07-22 6:35 ` Al Viro
2007-07-22 6:35 ` Al Viro
2007-07-22 6:39 ` David Miller
2007-07-22 6:39 ` David Miller
2007-07-22 7:22 ` Al Viro
2007-07-22 7:22 ` Al Viro
2007-07-22 7:26 ` [PATCH] sparc32 missing exports Al Viro
2007-07-22 7:26 ` Al Viro
2007-07-22 7:38 ` David Miller
2007-07-22 7:38 ` David Miller
2007-07-22 7:37 ` [RFC] Kconfig fun with sparc32/sparc64 rtc drivers David Miller
2007-07-22 7:37 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070722063149.GQ21668@ftp.linux.org.uk \
--to=viro@ftp.linux.org.uk \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.