All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Shawn O. Pearce" <spearce@spearce.org>
To: Yasushi SHOJI <yashi@atmark-techno.com>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [RFC] describe: add option --dirty
Date: Mon, 23 Jul 2007 03:58:34 -0400	[thread overview]
Message-ID: <20070723075834.GK32566@spearce.org> (raw)
In-Reply-To: <87lkd7mu71.wl@mail2.atmark-techno.com>

Yasushi SHOJI <yashi@atmark-techno.com> wrote:
> From the comments I'd add an option "--workinig-tree" instead of
> --dirty to describe the working tree.  because that, the special case,
> is what we want after all,
> 
> synopsis would be:
> 
> 	SYNOPSIS
> 	--------
> 	'git-describe' [--all] [--tags] [--contains] [--abbrev=<n>]
> 	               [--candidates=<n>] [--debug]
> 	               --working-tree | <committish>...
> 	    :
> 	    :
> 	--working-tree::
> 		Describe the working tree instead of committishes.  if the
> 		working tree is dirty, the describe string will have "-dirty"
> 		appended.
> 	
> 		As you can assume from the name, this option requires working
> 		tree; running it on a bare repository will fail.
> 
> what do you think?

That's reasonable.  It seems like a lot of work in core Git just
to avoid a small chunk of shell, but I think almost everyone has
that same small chunk of shell in their build scripts...

-- 
Shawn.

  reply	other threads:[~2007-07-23  7:58 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-23  6:35 [RFC] describe: add option --dirty Yasushi SHOJI
2007-07-23  6:56 ` Junio C Hamano
2007-07-23  7:08   ` Shawn O. Pearce
2007-07-23  7:54     ` Yasushi SHOJI
2007-07-23  7:58       ` Shawn O. Pearce [this message]
2007-07-23  8:52         ` Yasushi SHOJI
2007-07-23  6:59 ` Shawn O. Pearce

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070723075834.GK32566@spearce.org \
    --to=spearce@spearce.org \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=yashi@atmark-techno.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.