From: Adrian Bunk <bunk@stusta.de>
To: mark.fasheh@oracle.com, kurt.hackel@oracle.com
Cc: ocfs2-devel@oss.oracle.com, linux-kernel@vger.kernel.org
Subject: [Ocfs2-devel] [2.6 patch] ocfs2_insert_extent(): remove dead code
Date: Mon Jul 23 01:01:59 2007 [thread overview]
Message-ID: <20070723080121.GC26212@stusta.de> (raw)
This patch removes some now dead code.
Spotted by the Coverity checker.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
fs/ocfs2/alloc.c | 4 ----
1 file changed, 4 deletions(-)
--- linux-2.6.22-rc6-mm1/fs/ocfs2/alloc.c.old 2007-07-23 01:29:25.000000000 +0200
+++ linux-2.6.22-rc6-mm1/fs/ocfs2/alloc.c 2007-07-23 01:29:52.000000000 +0200
@@ -3500,7 +3500,6 @@ int ocfs2_insert_extent(struct ocfs2_sup
{
int status;
struct buffer_head *last_eb_bh = NULL;
- struct buffer_head *bh = NULL;
struct ocfs2_insert_type insert = {0, };
struct ocfs2_extent_rec rec;
@@ -3552,9 +3551,6 @@ int ocfs2_insert_extent(struct ocfs2_sup
ocfs2_extent_map_insert_rec(inode, &rec);
bail:
- if (bh)
- brelse(bh);
-
if (last_eb_bh)
brelse(last_eb_bh);
WARNING: multiple messages have this Message-ID (diff)
From: Adrian Bunk <bunk@stusta.de>
To: mark.fasheh@oracle.com, kurt.hackel@oracle.com
Cc: ocfs2-devel@oss.oracle.com, linux-kernel@vger.kernel.org
Subject: [2.6 patch] ocfs2_insert_extent(): remove dead code
Date: Mon, 23 Jul 2007 10:01:21 +0200 [thread overview]
Message-ID: <20070723080121.GC26212@stusta.de> (raw)
This patch removes some now dead code.
Spotted by the Coverity checker.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
fs/ocfs2/alloc.c | 4 ----
1 file changed, 4 deletions(-)
--- linux-2.6.22-rc6-mm1/fs/ocfs2/alloc.c.old 2007-07-23 01:29:25.000000000 +0200
+++ linux-2.6.22-rc6-mm1/fs/ocfs2/alloc.c 2007-07-23 01:29:52.000000000 +0200
@@ -3500,7 +3500,6 @@ int ocfs2_insert_extent(struct ocfs2_sup
{
int status;
struct buffer_head *last_eb_bh = NULL;
- struct buffer_head *bh = NULL;
struct ocfs2_insert_type insert = {0, };
struct ocfs2_extent_rec rec;
@@ -3552,9 +3551,6 @@ int ocfs2_insert_extent(struct ocfs2_sup
ocfs2_extent_map_insert_rec(inode, &rec);
bail:
- if (bh)
- brelse(bh);
-
if (last_eb_bh)
brelse(last_eb_bh);
next reply other threads:[~2007-07-23 1:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-23 1:01 Adrian Bunk [this message]
2007-07-23 8:01 ` [2.6 patch] ocfs2_insert_extent(): remove dead code Adrian Bunk
2007-07-24 5:53 ` [Ocfs2-devel] " Mark Fasheh
2007-07-24 12:53 ` Mark Fasheh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070723080121.GC26212@stusta.de \
--to=bunk@stusta.de \
--cc=kurt.hackel@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.fasheh@oracle.com \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.