From: Andrew Morton <akpm@linux-foundation.org>
To: Christoph Lameter <clameter@sgi.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
Mel Gorman <mel@skynet.ie>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Daniel Phillips <phillips@google.com>,
linux-mm <linux-mm@kvack.org>
Subject: Re: [PATCH] add __GFP_ZERO to GFP_LEVEL_MASK
Date: Tue, 24 Jul 2007 16:12:47 -0700 [thread overview]
Message-ID: <20070724161247.ee1a2546.akpm@linux-foundation.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0707241541310.7288@schroedinger.engr.sgi.com>
On Tue, 24 Jul 2007 16:00:32 -0700 (PDT) Christoph Lameter <clameter@sgi.com> wrote:
> On Tue, 24 Jul 2007, Andrew Morton wrote:
>
> > I think I'll duck this for now. Otherwise I have a suspicion that I'll
> > be the first person to run it and I'm too old for such excitement.
>
> I always had the suspicion that you have some magical script
> which will immediately tell you that a patch is not working ;-)
sort of a defensive crouch.
> Works fine on x86_64 (on top of the ctor cleanup patchset) and passes the
> kernel build test but then there may be creatively designed drivers and
> such that pass these flags to the slab allocators which will now BUG.
__GFP_COLD looks OK.
__GFP_COMP I'm not so sure about.
drivers/char/drm/drm_pci.c:drm_pci_alloc() (and other places like infiniband)
pass it into dma_alloc_coherent() which some architectures implement via slab. umm,
arch/arm/mm/consistent.c is one such.
__GFP_MOVABLE looks OK.
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: Christoph Lameter <clameter@sgi.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
Mel Gorman <mel@skynet.ie>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Daniel Phillips <phillips@google.com>,
linux-mm <linux-mm@kvack.org>
Subject: Re: [PATCH] add __GFP_ZERO to GFP_LEVEL_MASK
Date: Tue, 24 Jul 2007 16:12:47 -0700 [thread overview]
Message-ID: <20070724161247.ee1a2546.akpm@linux-foundation.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0707241541310.7288@schroedinger.engr.sgi.com>
On Tue, 24 Jul 2007 16:00:32 -0700 (PDT) Christoph Lameter <clameter@sgi.com> wrote:
> On Tue, 24 Jul 2007, Andrew Morton wrote:
>
> > I think I'll duck this for now. Otherwise I have a suspicion that I'll
> > be the first person to run it and I'm too old for such excitement.
>
> I always had the suspicion that you have some magical script
> which will immediately tell you that a patch is not working ;-)
sort of a defensive crouch.
> Works fine on x86_64 (on top of the ctor cleanup patchset) and passes the
> kernel build test but then there may be creatively designed drivers and
> such that pass these flags to the slab allocators which will now BUG.
__GFP_COLD looks OK.
__GFP_COMP I'm not so sure about.
drivers/char/drm/drm_pci.c:drm_pci_alloc() (and other places like infiniband)
pass it into dma_alloc_coherent() which some architectures implement via slab. umm,
arch/arm/mm/consistent.c is one such.
__GFP_MOVABLE looks OK.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2007-07-24 23:13 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-23 10:03 [PATCH] add __GFP_ZERP to GFP_LEVEL_MASK Peter Zijlstra
2007-07-23 10:03 ` Peter Zijlstra
2007-07-23 11:21 ` Mel Gorman
2007-07-23 11:21 ` Mel Gorman
2007-07-23 11:38 ` [PATCH] add __GFP_ZERO " Peter Zijlstra
2007-07-23 11:38 ` Peter Zijlstra
2007-07-23 12:30 ` Mel Gorman
2007-07-23 12:30 ` Mel Gorman
2007-07-23 23:17 ` Christoph Lameter
2007-07-23 23:17 ` Christoph Lameter
2007-07-24 6:01 ` Peter Zijlstra
2007-07-24 6:01 ` Peter Zijlstra
2007-07-24 6:48 ` Peter Zijlstra
2007-07-24 6:48 ` Peter Zijlstra
2007-07-24 7:14 ` Christoph Lameter
2007-07-24 7:14 ` Christoph Lameter
2007-07-24 7:09 ` Christoph Lameter
2007-07-24 7:09 ` Christoph Lameter
2007-07-24 7:24 ` Peter Zijlstra
2007-07-24 7:24 ` Peter Zijlstra
2007-07-24 7:35 ` Christoph Lameter
2007-07-24 7:35 ` Christoph Lameter
2007-07-24 19:07 ` Christoph Lameter
2007-07-24 19:07 ` Christoph Lameter
2007-07-24 19:25 ` Andrew Morton
2007-07-24 19:25 ` Andrew Morton
2007-07-24 19:36 ` Christoph Lameter
2007-07-24 19:36 ` Christoph Lameter
2007-07-24 22:10 ` Andrew Morton
2007-07-24 22:10 ` Andrew Morton
2007-07-24 23:00 ` Christoph Lameter
2007-07-24 23:00 ` Christoph Lameter
2007-07-24 23:12 ` Andrew Morton [this message]
2007-07-24 23:12 ` Andrew Morton
2007-07-24 23:58 ` Christoph Lameter
2007-07-24 23:58 ` Christoph Lameter
2007-07-25 0:06 ` Andrew Morton
2007-07-25 0:06 ` Andrew Morton
2007-07-25 13:06 ` Mel Gorman
2007-07-25 13:06 ` Mel Gorman
2007-07-23 18:37 ` [PATCH] add __GFP_ZERP " Andrew Morton
2007-07-23 18:37 ` Andrew Morton
2007-07-23 18:40 ` Peter Zijlstra
2007-07-23 18:40 ` Peter Zijlstra
2007-07-23 21:43 ` Christoph Lameter
2007-07-23 21:43 ` Christoph Lameter
2007-07-23 22:13 ` Andrew Morton
2007-07-23 22:13 ` Andrew Morton
2007-07-23 22:41 ` Linus Torvalds
2007-07-23 22:41 ` Linus Torvalds
2007-07-23 22:56 ` Andrew Morton
2007-07-23 22:56 ` Andrew Morton
2007-07-23 23:00 ` Christoph Lameter
2007-07-23 23:00 ` Christoph Lameter
2007-07-23 22:50 ` Christoph Lameter
2007-07-23 22:50 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070724161247.ee1a2546.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=a.p.zijlstra@chello.nl \
--cc=clameter@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mel@skynet.ie \
--cc=phillips@google.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.