From: Arnd Bergmann <arnd@arndb.de>
To: linuxppc-dev@ozlabs.org
Cc: linux-kernel@vger.kernel.org, paulus@samba.org
Subject: Re: [PATCH 3/5 v3] Add the platform device support with RapidIO to MPC8641HPCN platform.
Date: Sun, 29 Jul 2007 15:56:35 +0200 [thread overview]
Message-ID: <200707291556.35632.arnd@arndb.de> (raw)
In-Reply-To: <11854393753986-git-send-email-wei.zhang@freescale.com>
On Thursday 26 July 2007, Zhang Wei wrote:
> +
> +static struct of_device_id mpc86xx_of_ids[] =3D {
> +=A0=A0=A0=A0=A0=A0=A0{ .type =3D "soc", },
> +=A0=A0=A0=A0=A0=A0=A0{ .compatible =3D "fsl,rapidio-delta", },
> +=A0=A0=A0=A0=A0=A0=A0{},
> +};
With the device tree source you have posted in 2/5, the rapidio node is
a child of the soc bus, and it doesn't have any children of its own.
Therefore it is completely equivalent to _only_ add the soc type
to mpc86xx_of_ids[], as in=20
static struct of_device_id mpc86xx_of_ids[] =3D {
{ .type =3D "soc", },
{},
};
Even if you intend to add children to the rapidio node in the future,
I'd think it would be more appropriate to have those scanned by
the rapidio bus driver, not by of_platform.
Arnd <><
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: linuxppc-dev@ozlabs.org
Cc: Zhang Wei <wei.zhang@freescale.com>,
galak@kernel.crashing.org, mporter@kernel.crashing.org,
paulus@samba.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/5 v3] Add the platform device support with RapidIO to MPC8641HPCN platform.
Date: Sun, 29 Jul 2007 15:56:35 +0200 [thread overview]
Message-ID: <200707291556.35632.arnd@arndb.de> (raw)
In-Reply-To: <11854393753986-git-send-email-wei.zhang@freescale.com>
On Thursday 26 July 2007, Zhang Wei wrote:
> +
> +static struct of_device_id mpc86xx_of_ids[] = {
> + { .type = "soc", },
> + { .compatible = "fsl,rapidio-delta", },
> + {},
> +};
With the device tree source you have posted in 2/5, the rapidio node is
a child of the soc bus, and it doesn't have any children of its own.
Therefore it is completely equivalent to _only_ add the soc type
to mpc86xx_of_ids[], as in
static struct of_device_id mpc86xx_of_ids[] = {
{ .type = "soc", },
{},
};
Even if you intend to add children to the rapidio node in the future,
I'd think it would be more appropriate to have those scanned by
the rapidio bus driver, not by of_platform.
Arnd <><
next prev parent reply other threads:[~2007-07-29 20:39 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-26 8:42 [PATCH 0/5 v3] Porting RapidIO driver from ppc to powerpc architecture and adding memory mapped RapidIO driver Zhang Wei
2007-07-26 8:42 ` Zhang Wei
2007-07-26 8:42 ` [PATCH 1/5 v3] Add the explanation and a sample of RapidIO OF node to the document of booting-without-of.txt file Zhang Wei
2007-07-26 8:42 ` Zhang Wei
2007-07-26 8:42 ` [PATCH 2/5 v3] Add RapidIO OF-node to the MPC8641HPCN board dts file Zhang Wei
2007-07-26 8:42 ` Zhang Wei
2007-07-26 8:42 ` [PATCH 3/5 v3] Add the platform device support with RapidIO to MPC8641HPCN platform Zhang Wei
2007-07-26 8:42 ` Zhang Wei
2007-07-26 8:42 ` [PATCH 4/5 v3] Add RapidIO support to powerpc architecture Zhang Wei
2007-07-26 8:42 ` Zhang Wei
2007-07-26 8:42 ` [PATCH 5/5 v3] Add the memory management driver to RapidIO Zhang Wei
2007-07-26 8:42 ` Zhang Wei
2008-01-24 7:01 ` Kumar Gala
2008-01-24 7:01 ` Kumar Gala
2007-07-27 8:12 ` [PATCH 4/5 v3] Add RapidIO support to powerpc architecture Stephen Rothwell
2007-07-27 8:12 ` Stephen Rothwell
2007-07-27 8:22 ` Kumar Gala
2007-07-27 8:22 ` Kumar Gala
2007-07-27 9:03 ` Zhang Wei-r63237
2007-07-27 9:03 ` Zhang Wei-r63237
2007-07-27 7:54 ` [PATCH 3/5 v3] Add the platform device support with RapidIO to MPC8641HPCN platform Stephen Rothwell
2007-07-27 7:54 ` Stephen Rothwell
2007-07-29 13:56 ` Arnd Bergmann [this message]
2007-07-29 13:56 ` Arnd Bergmann
2007-07-30 8:26 ` Zhang Wei-r63237
2007-07-30 8:26 ` Zhang Wei-r63237
2007-07-27 8:51 ` [PATCH 1/5 v3] Add the explanation and a sample of RapidIO OF node to the document of booting-without-of.txt file Kumar Gala
2007-07-27 8:51 ` Kumar Gala
2007-07-27 9:12 ` Zhang Wei-r63237
2007-07-27 9:12 ` Zhang Wei-r63237
2007-07-31 16:15 ` Segher Boessenkool
2007-07-31 16:15 ` Segher Boessenkool
2007-07-31 16:19 ` Segher Boessenkool
2007-07-31 16:19 ` Segher Boessenkool
2007-07-27 8:28 ` [PATCH 0/5 v3] Porting RapidIO driver from ppc to powerpc architecture and adding memory mapped RapidIO driver Kumar Gala
2007-07-27 8:28 ` Kumar Gala
2007-10-29 19:38 ` Phil Terry
2007-10-29 19:38 ` Phil Terry
2007-10-29 20:30 ` Kumar Gala
2007-10-29 20:30 ` Kumar Gala
2007-10-30 8:40 ` Zhang Wei-r63237
2007-10-30 8:40 ` Zhang Wei-r63237
2007-11-09 22:34 ` Randy Vinson
2007-11-12 2:18 ` Zhang Wei-r63237
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200707291556.35632.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.