From: FUJITA Tomonori <tomof@acm.org>
To: brking@linux.vnet.ibm.com
Cc: James.Bottomley@steeleye.com, linux-scsi@vger.kernel.org,
fujita.tomonori@lab.ntt.co.jp
Subject: Re: [PATCH 1/1] scsi: Fix SRP_ATTRS Kconfig
Date: Wed, 1 Aug 2007 00:24:50 +0900 [thread overview]
Message-ID: <20070731154505V.tomof@acm.org> (raw)
In-Reply-To: <11858119293805-patch-mail.ibm.com>
From: Brian King <brking@linux.vnet.ibm.com>
Subject: [PATCH 1/1] scsi: Fix SRP_ATTRS Kconfig
Date: Mon, 30 Jul 2007 11:12:10 -0500
>
> Since the srp transport class was added, if scsi tgt support is not
> selected, the current Kconfig allows for enabling a dependent device
> driver, such as ibmvscsi, which does a select of SCSI_SRP_ATTRS. This
> does not, however, enable SCSI_TGT also. This fixes this up to prevent
> the following build problem:
>
> ERROR: ".scsi_tgt_it_nexus_create" [drivers/scsi/scsi_transport_srp.ko] undefined!
> ERROR: ".scsi_tgt_it_nexus_destroy" [drivers/scsi/scsi_transport_srp.ko] undefined!
>
> Signed-off-by: Brian King <brking@linux.vnet.ibm.com>
> ---
>
> scsi-pending-2.6.git-bjking1/drivers/scsi/Kconfig | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff -puN drivers/scsi/Kconfig~scsi_tgt_kconfig_fix drivers/scsi/Kconfig
> --- scsi-pending-2.6.git/drivers/scsi/Kconfig~scsi_tgt_kconfig_fix 2007-07-30 10:44:34.000000000 -0500
> +++ scsi-pending-2.6.git-bjking1/drivers/scsi/Kconfig 2007-07-30 10:45:00.000000000 -0500
> @@ -291,7 +291,8 @@ source "drivers/scsi/libsas/Kconfig"
>
> config SCSI_SRP_ATTRS
> tristate "SRP Transport Attributes"
> - depends on SCSI && SCSI_TGT
> + depends on SCSI
> + select SCSI_TGT
Thanks, but I guess that I should have made the srp transport class
independent of tgt since most people want only initiator support. I'll
send a patch to do that soon.
next parent reply other threads:[~2007-07-31 15:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <11858119293805-patch-mail.ibm.com>
2007-07-31 15:24 ` FUJITA Tomonori [this message]
2007-07-30 16:12 [PATCH 1/1] scsi: Fix SRP_ATTRS Kconfig Brian King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070731154505V.tomof@acm.org \
--to=tomof@acm.org \
--cc=James.Bottomley@steeleye.com \
--cc=brking@linux.vnet.ibm.com \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.