Re: [PATCH 1/1] scsi: Fix SRP_ATTRS Kconfig

Re: [PATCH 1/1] scsi: Fix SRP_ATTRS Kconfig

[FUJITA Tomonori]

From: Brian King <brking@linux.vnet.ibm.com>
Subject: [PATCH 1/1] scsi: Fix SRP_ATTRS Kconfig
Date: Mon, 30 Jul 2007 11:12:10 -0500

> 
> Since the srp transport class was added, if scsi tgt support is not
> selected, the current Kconfig allows for enabling a dependent device
> driver, such as ibmvscsi, which does a select of SCSI_SRP_ATTRS. This
> does not, however, enable SCSI_TGT also. This fixes this up to prevent
> the following build problem:
> 
> ERROR: ".scsi_tgt_it_nexus_create" [drivers/scsi/scsi_transport_srp.ko] undefined!
> ERROR: ".scsi_tgt_it_nexus_destroy" [drivers/scsi/scsi_transport_srp.ko] undefined!
> 
> Signed-off-by: Brian King <brking@linux.vnet.ibm.com>
> ---
> 
>  scsi-pending-2.6.git-bjking1/drivers/scsi/Kconfig |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff -puN drivers/scsi/Kconfig~scsi_tgt_kconfig_fix drivers/scsi/Kconfig
> --- scsi-pending-2.6.git/drivers/scsi/Kconfig~scsi_tgt_kconfig_fix	2007-07-30 10:44:34.000000000 -0500
> +++ scsi-pending-2.6.git-bjking1/drivers/scsi/Kconfig	2007-07-30 10:45:00.000000000 -0500
> @@ -291,7 +291,8 @@ source "drivers/scsi/libsas/Kconfig"
>  
>  config SCSI_SRP_ATTRS
>  	tristate "SRP Transport Attributes"
> -	depends on SCSI && SCSI_TGT
> +	depends on SCSI
> +	select SCSI_TGT

Thanks, but I guess that I should have made the srp transport class
independent of tgt since most people want only initiator support. I'll
send a patch to do that soon.

[PATCH 1/1] scsi: Fix SRP_ATTRS Kconfig

[Brian King]

Since the srp transport class was added, if scsi tgt support is not
selected, the current Kconfig allows for enabling a dependent device
driver, such as ibmvscsi, which does a select of SCSI_SRP_ATTRS. This
does not, however, enable SCSI_TGT also. This fixes this up to prevent
the following build problem:

ERROR: ".scsi_tgt_it_nexus_create" [drivers/scsi/scsi_transport_srp.ko] undefined!
ERROR: ".scsi_tgt_it_nexus_destroy" [drivers/scsi/scsi_transport_srp.ko] undefined!

Signed-off-by: Brian King <brking@linux.vnet.ibm.com>
---

 scsi-pending-2.6.git-bjking1/drivers/scsi/Kconfig |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff -puN drivers/scsi/Kconfig~scsi_tgt_kconfig_fix drivers/scsi/Kconfig
--- scsi-pending-2.6.git/drivers/scsi/Kconfig~scsi_tgt_kconfig_fix	2007-07-30 10:44:34.000000000 -0500
+++ scsi-pending-2.6.git-bjking1/drivers/scsi/Kconfig	2007-07-30 10:45:00.000000000 -0500
@@ -291,7 +291,8 @@ source "drivers/scsi/libsas/Kconfig"
 
 config SCSI_SRP_ATTRS
 	tristate "SRP Transport Attributes"
-	depends on SCSI && SCSI_TGT
+	depends on SCSI
+	select SCSI_TGT
 	help
 	  If you wish to export transport-specific information about
 	  each attached SRP device to sysfs, say Y.
_