All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chr <chunkeey@web.de>
To: Jiri Kosina <jikos@jikos.cz>
Cc: linux-input@atrey.karlin.mff.cuni.cz,
	linux-kernel@vger.kernel.org,
	linux-usb-devel@lists.sourceforge.net
Subject: Cleaning up the USBHID's blacklist.
Date: Tue, 31 Jul 2007 23:24:05 +0200	[thread overview]
Message-ID: <200707312324.06116.chunkeey@web.de> (raw)
In-Reply-To: <Pine.LNX.4.64.0707311038400.5747@twin.jikos.cz>

On Tuesday, 31. July 2007, Jiri Kosina wrote:
> On Mon, 30 Jul 2007, Chr wrote:
> 
> > Ok, found it " hid_blacklist is alphabetically sorted blacklist by quirk 
> > type. " But is there a Order for the bitfields? e.g
> > shouldn't: hid-quriks.c (line 439, 440)
> > { USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_FOUNTAIN_ANSI, 
> > HID_QUIRK_POWERBOOK_HAS_FN | HID_QUIRK_IGNORE_MOUSE } 
> > be:
> > {..., ..., HID_QUIRK_IGNORE_MOUSE | HID_QUIRK_POWERBOOK_HAS_FN }
> 
> This could be a possible cleanup for hid_blacklist[], if you are going to 
> make a patch I will happily accept it.
> 
> Thanks,
> 
Ok! I'll make a patch..

But I have one (final?) question. Since I am sometimes stuck to 80x25 console...
 can we alphabetically sort the blacklist by the Vendor (the first field), instead of the quirk field(last field)?
Or is there a technical/theoretical reason behind it?   

Thanks,
	Chr.

  reply	other threads:[~2007-07-31 21:24 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-24  0:28 [PATCH] usbhid: add ASUS LCM to the blacklist Christian Lamparter
2007-07-24  0:28 ` Christian Lamparter
2007-07-26 22:27 ` Andrew Morton
2007-07-26 23:10   ` Christian Lamparter
2007-07-30 12:45     ` Jiri Kosina
2007-07-30 14:11       ` Chr
2007-07-30 14:11         ` Chr
2007-07-31  8:39         ` Jiri Kosina
2007-07-31 21:24           ` Chr [this message]
2007-08-01 12:11             ` Cleaning up the USBHID's blacklist Jiri Kosina
2007-10-11  1:11 ` [PATCH] usbhid: add ASUS LCM to the blacklist Javier Bolaños Molina
2007-10-12  8:49   ` Chr
2007-10-12  8:49     ` Chr
2007-10-12 15:59     ` Javier Bolaños Molina

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200707312324.06116.chunkeey@web.de \
    --to=chunkeey@web.de \
    --cc=jikos@jikos.cz \
    --cc=linux-input@atrey.karlin.mff.cuni.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.