From: Chr <chunkeey@web.de>
To: Jiri Kosina <jikos@jikos.cz>
Cc: linux-usb-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org,
Adilson Oliveira <adilson@linuxembarcado.com.br>,
linux-input@atrey.karlin.mff.cuni.cz,
Andrew Morton <akpm@linux-foundation.org>,
Bernd Dau <bernd@daucity.de>
Subject: Re: [PATCH] usbhid: add ASUS LCM to the blacklist
Date: Mon, 30 Jul 2007 16:11:07 +0200 [thread overview]
Message-ID: <200707301611.08758.chunkeey@web.de> (raw)
In-Reply-To: <Pine.LNX.4.64.0707301440020.5747@twin.jikos.cz>
On Monday, 30. July 2007, Jiri Kosina wrote:
> On Fri, 27 Jul 2007, Christian Lamparter wrote:
>
> > Some of ASUS' notebooks (e.g G Series) include a tiny oled display, which is
> > attached to an internal USB bus. Unfortunatly the device reports a wrong
> > DeviceDescriptor and is therefore identified as a HID device...
>
> Hi Christian,
>
> I have slightly modified your patch (let's keep the hid_blacklist[]
> properly sorted) and applied it into my tree.
Ok, found it " hid_blacklist is alphabetically sorted blacklist by quirk type. "
But is there a Order for the bitfields? e.g
shouldn't: hid-quriks.c (line 439, 440)
{ USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_FOUNTAIN_ANSI,
HID_QUIRK_POWERBOOK_HAS_FN | HID_QUIRK_IGNORE_MOUSE }
be:
{..., ..., HID_QUIRK_IGNORE_MOUSE | HID_QUIRK_POWERBOOK_HAS_FN }
Anyway, thanks for merging!
Chr.
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
WARNING: multiple messages have this Message-ID (diff)
From: Chr <chunkeey@web.de>
To: Jiri Kosina <jikos@jikos.cz>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org,
linux-usb-devel@lists.sourceforge.net,
linux-input@atrey.karlin.mff.cuni.cz,
Bernd Dau <bernd@daucity.de>,
Adilson Oliveira <adilson@linuxembarcado.com.br>
Subject: Re: [PATCH] usbhid: add ASUS LCM to the blacklist
Date: Mon, 30 Jul 2007 16:11:07 +0200 [thread overview]
Message-ID: <200707301611.08758.chunkeey@web.de> (raw)
In-Reply-To: <Pine.LNX.4.64.0707301440020.5747@twin.jikos.cz>
On Monday, 30. July 2007, Jiri Kosina wrote:
> On Fri, 27 Jul 2007, Christian Lamparter wrote:
>
> > Some of ASUS' notebooks (e.g G Series) include a tiny oled display, which is
> > attached to an internal USB bus. Unfortunatly the device reports a wrong
> > DeviceDescriptor and is therefore identified as a HID device...
>
> Hi Christian,
>
> I have slightly modified your patch (let's keep the hid_blacklist[]
> properly sorted) and applied it into my tree.
Ok, found it " hid_blacklist is alphabetically sorted blacklist by quirk type. "
But is there a Order for the bitfields? e.g
shouldn't: hid-quriks.c (line 439, 440)
{ USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_FOUNTAIN_ANSI,
HID_QUIRK_POWERBOOK_HAS_FN | HID_QUIRK_IGNORE_MOUSE }
be:
{..., ..., HID_QUIRK_IGNORE_MOUSE | HID_QUIRK_POWERBOOK_HAS_FN }
Anyway, thanks for merging!
Chr.
next prev parent reply other threads:[~2007-07-30 14:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-24 0:28 [PATCH] usbhid: add ASUS LCM to the blacklist Christian Lamparter
2007-07-24 0:28 ` Christian Lamparter
2007-07-26 22:27 ` Andrew Morton
2007-07-26 23:10 ` Christian Lamparter
2007-07-30 12:45 ` Jiri Kosina
2007-07-30 14:11 ` Chr [this message]
2007-07-30 14:11 ` Chr
2007-07-31 8:39 ` Jiri Kosina
2007-07-31 21:24 ` Cleaning up the USBHID's blacklist Chr
2007-08-01 12:11 ` Jiri Kosina
2007-10-11 1:11 ` [PATCH] usbhid: add ASUS LCM to the blacklist Javier Bolaños Molina
2007-10-12 8:49 ` Chr
2007-10-12 8:49 ` Chr
2007-10-12 15:59 ` Javier Bolaños Molina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200707301611.08758.chunkeey@web.de \
--to=chunkeey@web.de \
--cc=adilson@linuxembarcado.com.br \
--cc=akpm@linux-foundation.org \
--cc=bernd@daucity.de \
--cc=jikos@jikos.cz \
--cc=linux-input@atrey.karlin.mff.cuni.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.