* [PATCH] net: smc91x: Build fixes for general sh boards.
@ 2007-08-01 6:48 Paul Mundt
2007-08-07 21:18 ` Jeff Garzik
0 siblings, 1 reply; 2+ messages in thread
From: Paul Mundt @ 2007-08-01 6:48 UTC (permalink / raw)
To: Jeff Garzik; +Cc: linux-kernel, Andrew Morton
SH boards in general only wire this up in 8 or 16-bit mode, and
as we never had the wrappers for 32-bit mode defined, SMC_CAN_USE_32BIT
caused build failure for the non-Solution Engine boards. This gets it
building again.
Also kill off the straggling set_irq_type() definition, this is left
over cruft that was missed when the rest of it switched to IRQ flags.
Signed-off-by: Paul Mundt <lethal@linux-sh.org>
--
drivers/net/smc91x.h | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/net/smc91x.h b/drivers/net/smc91x.h
index f842944..6ff3a16 100644
--- a/drivers/net/smc91x.h
+++ b/drivers/net/smc91x.h
@@ -299,7 +299,7 @@ SMC_outw(u16 val, void __iomem *ioaddr, int reg)
#define SMC_CAN_USE_8BIT 1
#define SMC_CAN_USE_16BIT 1
-#define SMC_CAN_USE_32BIT 1
+#define SMC_CAN_USE_32BIT 0
#define SMC_inb(a, r) inb((a) + (r))
#define SMC_inw(a, r) inw((a) + (r))
@@ -310,8 +310,6 @@ SMC_outw(u16 val, void __iomem *ioaddr, int reg)
#endif /* BOARDS */
-#define set_irq_type(irq, type) do {} while (0)
-
#elif defined(CONFIG_M32R)
#define SMC_CAN_USE_8BIT 0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net: smc91x: Build fixes for general sh boards.
2007-08-01 6:48 [PATCH] net: smc91x: Build fixes for general sh boards Paul Mundt
@ 2007-08-07 21:18 ` Jeff Garzik
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2007-08-07 21:18 UTC (permalink / raw)
To: Paul Mundt, Jeff Garzik, linux-kernel, Andrew Morton
Paul Mundt wrote:
> SH boards in general only wire this up in 8 or 16-bit mode, and
> as we never had the wrappers for 32-bit mode defined, SMC_CAN_USE_32BIT
> caused build failure for the non-Solution Engine boards. This gets it
> building again.
>
> Also kill off the straggling set_irq_type() definition, this is left
> over cruft that was missed when the rest of it switched to IRQ flags.
>
> Signed-off-by: Paul Mundt <lethal@linux-sh.org>
applied to #upstream-fixes
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-08-07 21:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-08-01 6:48 [PATCH] net: smc91x: Build fixes for general sh boards Paul Mundt
2007-08-07 21:18 ` Jeff Garzik
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.