From: Andrew Morton <akpm@linux-foundation.org>
To: "Jesper Juhl" <jesper.juhl@gmail.com>
Cc: "Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"James Bottomley" <James.Bottomley@steeleye.com>,
"Christoph Lameter" <clameter@sgi.com>,
"Pekka Enberg" <penberg@cs.helsinki.fi>,
linux-mm@kvack.org, "Ingo Molnar" <mingo@elte.hu>,
"Matt Mackall" <mpm@selenic.com>
Subject: Re: [PATCH] Fix two potential mem leaks in MPT Fusion (mpt_attach())
Date: Thu, 2 Aug 2007 16:17:30 -0700 [thread overview]
Message-ID: <20070802161730.1d5bb55b.akpm@linux-foundation.org> (raw)
In-Reply-To: <9a8748490708021610k31a86c17y58fb631a36dfdb6a@mail.gmail.com>
On Fri, 3 Aug 2007 01:10:02 +0200
"Jesper Juhl" <jesper.juhl@gmail.com> wrote:
> > > So, where do we go from here?
> >
> > Where I said ;) Add a new __GFP_ flag which suppresses the warning, add
> > that flag to known-to-be-OK callsites, such as mempool_alloc().
> >
> Ok, I'll try to play around with this some more, try to filter out
> false positives and see what I'm left with (if anything - I'm pretty
> limited hardware-wise, so I can only test a small subset of drivers,
> archs etc) - I'll keep you informed, but expect a few days to pass
> before I have any news...
Make it a once-off thing for now, so the warning will disable itself after
it has triggered once. That will prevent the debug feature from making
anyone's kernel unusable.
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: Jesper Juhl <jesper.juhl@gmail.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
James Bottomley <James.Bottomley@steeleye.com>,
Christoph Lameter <clameter@sgi.com>,
Pekka Enberg <penberg@cs.helsinki.fi>,
linux-mm@kvack.org, Ingo Molnar <mingo@elte.hu>,
Matt Mackall <mpm@selenic.com>
Subject: Re: [PATCH] Fix two potential mem leaks in MPT Fusion (mpt_attach())
Date: Thu, 2 Aug 2007 16:17:30 -0700 [thread overview]
Message-ID: <20070802161730.1d5bb55b.akpm@linux-foundation.org> (raw)
In-Reply-To: <9a8748490708021610k31a86c17y58fb631a36dfdb6a@mail.gmail.com>
On Fri, 3 Aug 2007 01:10:02 +0200
"Jesper Juhl" <jesper.juhl@gmail.com> wrote:
> > > So, where do we go from here?
> >
> > Where I said ;) Add a new __GFP_ flag which suppresses the warning, add
> > that flag to known-to-be-OK callsites, such as mempool_alloc().
> >
> Ok, I'll try to play around with this some more, try to filter out
> false positives and see what I'm left with (if anything - I'm pretty
> limited hardware-wise, so I can only test a small subset of drivers,
> archs etc) - I'll keep you informed, but expect a few days to pass
> before I have any news...
Make it a once-off thing for now, so the warning will disable itself after
it has triggered once. That will prevent the debug feature from making
anyone's kernel unusable.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2007-08-02 23:18 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-01 23:55 [PATCH] Fix two potential mem leaks in MPT Fusion (mpt_attach()) Jesper Juhl
2007-08-02 0:26 ` Andrew Morton
2007-08-02 3:03 ` Matthew Wilcox
2007-08-02 5:13 ` Andrew Morton
2007-08-02 8:20 ` Jesper Juhl
2007-08-02 22:53 ` Jesper Juhl
2007-08-02 22:53 ` Jesper Juhl
2007-08-02 23:04 ` Andrew Morton
2007-08-02 23:04 ` Andrew Morton
2007-08-02 23:10 ` Jesper Juhl
2007-08-02 23:10 ` Jesper Juhl
2007-08-02 23:17 ` Andrew Morton [this message]
2007-08-02 23:17 ` Andrew Morton
2007-08-02 23:26 ` Jesper Juhl
2007-08-02 23:26 ` Jesper Juhl
2007-08-03 0:47 ` Christoph Lameter
2007-08-03 0:47 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070802161730.1d5bb55b.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=James.Bottomley@steeleye.com \
--cc=clameter@sgi.com \
--cc=jesper.juhl@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@elte.hu \
--cc=mpm@selenic.com \
--cc=penberg@cs.helsinki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.