Re: [PATCH][ELF] Correct space calculation for symtab when BSD_SYMTAB=yes

["Christoph Egger" <Christoph.Egger@amd.com>]

On Thursday 02 August 2007 15:21:34 Keir Fraser wrote:
> On 2/8/07 13:26, "Christoph Egger" <Christoph.Egger@amd.com> wrote:
> >> What do the virtual addresses of the symtab/strtab sections have to
> >> do with their location in the final address space, after loading? And
> >> since you pack the sections into the domain address space in
> >> elf_xen_dom_load_binary(), should you not simply sum the sizes of the
> >> sections, then sstart=virt_kend and send=sstart+size_sum, rather than
> >> taking max(end addresses in elf image) minus min(start addresses in elf
> >> image).
> >
> > You're right. Attached is a patch, which does it that way.
>
> Please try changeset 15679 in the -unstable staging tree. It's less code
> and also fixed up to work with the domU domain builder too. Except it's not
> actually been tested with a bsd_symtab guest kernel. It shouldn't need more
> than a few lines of fixing to get it working though, if that.
>
>  -- Keir

I tested this both with a Dom0 and DomU guest domain. It works!
Thanks a lot.


Christoph



-- 
AMD Saxony, Dresden, Germany
Operating System Research Center

Legal Information:
AMD Saxony Limited Liability Company & Co. KG
Sitz (Geschäftsanschrift):
   Wilschdorfer Landstr. 101, 01109 Dresden, Deutschland
Registergericht Dresden: HRA 4896
vertretungsberechtigter Komplementär:
   AMD Saxony LLC (Sitz Wilmington, Delaware, USA)
Geschäftsführer der AMD Saxony LLC:
   Dr. Hans-R. Deppe, Thomas McCoy