All of lore.kernel.org
 help / color / mirror / Atom feed
From: Keir Fraser <keir@xensource.com>
To: Christoph Egger <Christoph.Egger@amd.com>, xen-devel@lists.xensource.com
Subject: Re: [PATCH][ELF] Correct space calculation for symtab when BSD_SYMTAB=yes
Date: Thu, 02 Aug 2007 14:21:34 +0100	[thread overview]
Message-ID: <C2D798EE.137AC%keir@xensource.com> (raw)
In-Reply-To: <200708021426.59206.Christoph.Egger@amd.com>

On 2/8/07 13:26, "Christoph Egger" <Christoph.Egger@amd.com> wrote:

>> What do the virtual addresses of the symtab/strtab sections have to
>> do with their location in the final address space, after loading? And since
>> you pack the sections into the domain address space in
>> elf_xen_dom_load_binary(), should you not simply sum the sizes of the
>> sections, then sstart=virt_kend and send=sstart+size_sum, rather than
>> taking max(end addresses in elf image) minus min(start addresses in elf
>> image).
> 
> You're right. Attached is a patch, which does it that way.

Please try changeset 15679 in the -unstable staging tree. It's less code and
also fixed up to work with the domU domain builder too. Except it's not
actually been tested with a bsd_symtab guest kernel. It shouldn't need more
than a few lines of fixing to get it working though, if that.

 -- Keir

  reply	other threads:[~2007-08-02 13:21 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-02  8:03 [PATCH][ELF] Correct space calculation for symtab when BSD_SYMTAB=yes Christoph Egger
2007-08-02  8:49 ` Keir Fraser
2007-08-02 12:26   ` Christoph Egger
2007-08-02 13:21     ` Keir Fraser [this message]
2007-08-02 16:52       ` Christoph Egger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=C2D798EE.137AC%keir@xensource.com \
    --to=keir@xensource.com \
    --cc=Christoph.Egger@amd.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.