ACPI: thinkpad-acpi: change thinkpad-acpi input default and kconfig help

ACPI: thinkpad-acpi: change thinkpad-acpi input default and kconfig help

[Henrique de Moraes Holschuh]

The current kconfig help text was misleading users.  Also, the default for
an input-layer-optimized support caused way too many problems without
up-to-date userspace in place.

So, rework the help text, and change the default to N.  Note that
distributions are supposed to enable this option as soon as they update HAL
to a version that handles the thinkpad-acpi new input layer interface.

Signed-off-by: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Cc: Michael S. Tsirkin <mst@dev.mellanox.co.il>
Cc: Hugh Dickins <hugh@veritas.com>
---
 drivers/misc/Kconfig |   22 +++++++++++++++-------
 1 files changed, 15 insertions(+), 7 deletions(-)

diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig
index aaaa61e..518d5d3 100644
--- a/drivers/misc/Kconfig
+++ b/drivers/misc/Kconfig
@@ -200,14 +200,22 @@ config THINKPAD_ACPI_BAY
 config THINKPAD_ACPI_INPUT_ENABLED
 	bool "Enable input layer support by default"
 	depends on THINKPAD_ACPI
-	default y
+	default n
 	---help---
-	  Enables hot key handling over the input layer by default.  If unset,
-	  the driver does not enable any hot key handling by default, and also
-	  starts up with a mostly empty keymap.
-
-	  If you are not sure, say Y here.  Say N to retain the deprecated
-	  behavior of ibm-acpi, and thinkpad-acpi for kernels up to 2.6.21.
+	  This option enables thinkpad-acpi hot key handling over the input
+	  layer at driver load time.  When it is unset, the driver does not
+	  enable hot key handling by default, and also starts up with a mostly
+	  empty keymap.
+
+	  This option should be enabled if you have a new enough HAL or other
+	  userspace support that properly handles the thinkpad-acpi event
+	  device.  It auto-tunes the hot key support to those reported by the
+	  firmware and enables it automatically.
+
+	  If unsure, say N here to retain the old behaviour of ibm-acpi, and
+	  thinkpad-acpi up to kernel 2.6.21: userspace will have to enable and
+	  set up the thinkpad-acpi hot key handling using the sysfs interace
+	  after loading the driver.
 
 
 endif # MISC_DEVICES
-- 
1.5.2.1

Re: ACPI: thinkpad-acpi: change thinkpad-acpi input default and kconfig help

[Len Brown]

Applied.

thanks,
-Len

On Sunday 05 August 2007 14:20, Henrique de Moraes Holschuh wrote:
> The current kconfig help text was misleading users.  Also, the default for
> an input-layer-optimized support caused way too many problems without
> up-to-date userspace in place.
> 
> So, rework the help text, and change the default to N.  Note that
> distributions are supposed to enable this option as soon as they update HAL
> to a version that handles the thinkpad-acpi new input layer interface.
> 
> Signed-off-by: Henrique de Moraes Holschuh <hmh-N3TV7GIv+o9fyO9Q7EP/yw@public.gmane.org>
> Cc: Michael S. Tsirkin <mst-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
> Cc: Hugh Dickins <hugh-DTz5qymZ9yRBDgjK7y7TUQ@public.gmane.org>
> ---
>  drivers/misc/Kconfig |   22 +++++++++++++++-------
>  1 files changed, 15 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig
> index aaaa61e..518d5d3 100644
> --- a/drivers/misc/Kconfig
> +++ b/drivers/misc/Kconfig
> @@ -200,14 +200,22 @@ config THINKPAD_ACPI_BAY
>  config THINKPAD_ACPI_INPUT_ENABLED
>  	bool "Enable input layer support by default"
>  	depends on THINKPAD_ACPI
> -	default y
> +	default n
>  	---help---
> -	  Enables hot key handling over the input layer by default.  If unset,
> -	  the driver does not enable any hot key handling by default, and also
> -	  starts up with a mostly empty keymap.
> -
> -	  If you are not sure, say Y here.  Say N to retain the deprecated
> -	  behavior of ibm-acpi, and thinkpad-acpi for kernels up to 2.6.21.
> +	  This option enables thinkpad-acpi hot key handling over the input
> +	  layer at driver load time.  When it is unset, the driver does not
> +	  enable hot key handling by default, and also starts up with a mostly
> +	  empty keymap.
> +
> +	  This option should be enabled if you have a new enough HAL or other
> +	  userspace support that properly handles the thinkpad-acpi event
> +	  device.  It auto-tunes the hot key support to those reported by the
> +	  firmware and enables it automatically.
> +
> +	  If unsure, say N here to retain the old behaviour of ibm-acpi, and
> +	  thinkpad-acpi up to kernel 2.6.21: userspace will have to enable and
> +	  set up the thinkpad-acpi hot key handling using the sysfs interace
> +	  after loading the driver.
>  
>  
>  endif # MISC_DEVICES

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/