All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: lguest <lguest@ozlabs.org>,
	lkml - Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	virtualization <virtualization@lists.linux-foundation.org>,
	Glauber de Oliveira Costa <glommer@gmail.com>,
	Jes Sorensen <jes@sgi.com>, Carsten Otte <cotte@de.ibm.com>
Subject: [PATCH 6/7] Remove __pa() use in hvc_lguest
Date: Wed, 08 Aug 2007 20:32:17 -0400	[thread overview]
Message-ID: <20070809003343.991452371@goodmis.org> (raw)
In-Reply-To: 20070809003211.373543702@goodmis.org

[-- Attachment #1: 0006-Remove-__pa-use-in-hvc_lguest-in-const-initialization.txt --]
[-- Type: text/plain, Size: 1131 bytes --]

The hvc_lguest uses __pa in the const initialization.
In some architectures, __pa() is not constant so this fails in compiles.

Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
---
 drivers/char/hvc_lguest.c |    8 +++++++-
 1 files changed, 7 insertions(+), 1 deletions(-)

diff --git a/drivers/char/hvc_lguest.c b/drivers/char/hvc_lguest.c
index feeccba..c7d7d4c 100644
--- a/drivers/char/hvc_lguest.c
+++ b/drivers/char/hvc_lguest.c
@@ -42,7 +42,6 @@
  * use of physical address for the buffer itself. */
 static char inbuf[256];
 static struct lguest_dma cons_input = { .used_len = 0,
-					.addr[0] = __pa(inbuf),
 					.len[0] = sizeof(inbuf),
 					.len[1] = 0 };
 
@@ -114,6 +113,13 @@ static struct hv_ops lguest_cons = {
  * (0), and the struct hv_ops containing the put_chars() function. */
 static int __init cons_init(void)
 {
+	/*
+	 * We can't initialize using __pa in const declarations,
+	 * since __pa(inbuf) does not evaluate into a constant on
+	 * all architectures (namely x86_64).
+	 */
+	cons_input.addr[0] = __pa(inbuf);
+
 	if (strcmp(paravirt_ops.name, "lguest") != 0)
 		return 0;
 
-- 
1.4.4.4

-- 

  parent reply	other threads:[~2007-08-09  0:37 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-09  0:32 [PATCH 0/7] Modify lguest32 to make room for lguest64 Steven Rostedt
2007-08-09  0:32 ` [PATCH 1/7] Move lg.h to the i386 specific lguest directory Steven Rostedt
2007-08-09  0:32 ` Steven Rostedt
2007-08-09  0:32 ` [PATCH 2/7] Added generic lg.h in " Steven Rostedt
2007-08-09  0:56   ` Glauber de Oliveira Costa
2007-08-09 12:06     ` Jes Sorensen
2007-08-09 12:06     ` Jes Sorensen
2007-08-09  0:56   ` Glauber de Oliveira Costa
2007-08-09  1:45   ` Stephen Rothwell
2007-08-09  2:17     ` Steven Rostedt
2007-08-09  2:17     ` Steven Rostedt
2007-08-09  1:45   ` Stephen Rothwell
2007-08-09  0:32 ` Steven Rostedt
2007-08-09  0:32 ` [PATCH 3/7] Move the lguest files that are i386 specific Steven Rostedt
2007-08-09  0:32 ` Steven Rostedt
2007-08-09  0:32 ` [PATCH 4/7] Moved the io struct up to the generic lg.h Steven Rostedt
2007-08-09  1:51   ` Stephen Rothwell
2007-08-09  1:51   ` Stephen Rothwell
2007-08-09  2:19     ` Steven Rostedt
2007-08-09  2:19     ` Steven Rostedt
2007-08-09 12:26     ` Jes Sorensen
2007-08-09 12:40       ` Steven Rostedt
2007-08-09 12:40         ` Steven Rostedt
2007-08-09 12:26     ` Jes Sorensen
2007-08-09  0:32 ` Steven Rostedt
2007-08-09  0:32 ` [PATCH 5/7] Change lguest launcher to use asm generic include Steven Rostedt
2007-08-09  0:32 ` Steven Rostedt
2007-08-09  1:05   ` Glauber de Oliveira Costa
2007-08-09  1:05   ` Glauber de Oliveira Costa
2007-08-11  3:11   ` Rusty Russell
2007-08-11  3:11   ` Rusty Russell
2007-08-09  0:32 ` Steven Rostedt [this message]
2007-08-09  0:32 ` [PATCH 6/7] Remove __pa() use in hvc_lguest Steven Rostedt
2007-08-09  0:32 ` [PATCH 7/7] Move lguest_dma_info into generic lg.h Steven Rostedt
2007-08-09  0:32 ` Steven Rostedt
2007-08-11  3:42 ` [PATCH 0/7] Modify lguest32 to make room for lguest64 Rusty Russell
2007-08-13  9:50   ` Jes Sorensen
2007-08-13  9:50     ` Jes Sorensen
2007-08-13 15:01   ` Jes Sorensen
2007-08-11  3:42 ` Rusty Russell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070809003343.991452371@goodmis.org \
    --to=rostedt@goodmis.org \
    --cc=akpm@linux-foundation.org \
    --cc=cotte@de.ibm.com \
    --cc=glommer@gmail.com \
    --cc=jes@sgi.com \
    --cc=lguest@ozlabs.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rusty@rustcorp.com.au \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.