From: Jes Sorensen <jes@sgi.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Steven Rostedt <rostedt@goodmis.org>,
Rusty Russell <rusty@rustcorp.com.au>, lguest <lguest@ozlabs.org>,
lkml - Kernel Mailing List <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
virtualization <virtualization@lists.linux-foundation.org>,
Glauber de Oliveira Costa <glommer@gmail.com>,
Carsten Otte <cotte@de.ibm.com>
Subject: Re: [PATCH 4/7] Moved the io struct up to the generic lg.h
Date: Thu, 09 Aug 2007 14:26:55 +0200 [thread overview]
Message-ID: <46BB080F.4040905@sgi.com> (raw)
In-Reply-To: <20070809115156.ef5fdc6c.sfr@canb.auug.org.au>
Stephen Rothwell wrote:
> On Wed, 08 Aug 2007 20:32:15 -0400 Steven Rostedt <rostedt@goodmis.org>
> wrote:
>> diff --git a/drivers/lguest/i386/lg.h b/drivers/lguest/i386/lg.h
>> index 64f0abe..c5ea14c 100644
>> --- a/drivers/lguest/i386/lg.h
>> +++ b/drivers/lguest/i386/lg.h
>> @@ -20,6 +20,8 @@
>> #include <linux/err.h>
>> #include <asm/semaphore.h>
>> #include "irq_vectors.h"
>> +/* some files include this, some include the parent */
>> +#include "../lg.h"
>
> Surely everything should just include the parent which allows for easier
> consolidation over time. (as you are doing here)
Whats wrong with introducing an include/asm-<arch>/lg.h and have the
parent do #include <asm/lg.h> ? Seems much cleaner to me.
Cheers,
Jes
next prev parent reply other threads:[~2007-08-09 12:27 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-09 0:32 [PATCH 0/7] Modify lguest32 to make room for lguest64 Steven Rostedt
2007-08-09 0:32 ` [PATCH 1/7] Move lg.h to the i386 specific lguest directory Steven Rostedt
2007-08-09 0:32 ` Steven Rostedt
2007-08-09 0:32 ` [PATCH 2/7] Added generic lg.h in " Steven Rostedt
2007-08-09 0:32 ` Steven Rostedt
2007-08-09 0:56 ` Glauber de Oliveira Costa
2007-08-09 0:56 ` Glauber de Oliveira Costa
2007-08-09 12:06 ` Jes Sorensen
2007-08-09 12:06 ` Jes Sorensen
2007-08-09 1:45 ` Stephen Rothwell
2007-08-09 1:45 ` Stephen Rothwell
2007-08-09 2:17 ` Steven Rostedt
2007-08-09 2:17 ` Steven Rostedt
2007-08-09 0:32 ` [PATCH 3/7] Move the lguest files that are i386 specific Steven Rostedt
2007-08-09 0:32 ` Steven Rostedt
2007-08-09 0:32 ` [PATCH 4/7] Moved the io struct up to the generic lg.h Steven Rostedt
2007-08-09 0:32 ` Steven Rostedt
2007-08-09 1:51 ` Stephen Rothwell
2007-08-09 1:51 ` Stephen Rothwell
2007-08-09 2:19 ` Steven Rostedt
2007-08-09 2:19 ` Steven Rostedt
2007-08-09 12:26 ` Jes Sorensen [this message]
2007-08-09 12:40 ` Steven Rostedt
2007-08-09 12:40 ` Steven Rostedt
2007-08-09 12:26 ` Jes Sorensen
2007-08-09 0:32 ` [PATCH 5/7] Change lguest launcher to use asm generic include Steven Rostedt
2007-08-09 1:05 ` Glauber de Oliveira Costa
2007-08-09 1:05 ` Glauber de Oliveira Costa
2007-08-11 3:11 ` Rusty Russell
2007-08-11 3:11 ` Rusty Russell
2007-08-09 0:32 ` Steven Rostedt
2007-08-09 0:32 ` [PATCH 6/7] Remove __pa() use in hvc_lguest Steven Rostedt
2007-08-09 0:32 ` Steven Rostedt
2007-08-09 0:32 ` [PATCH 7/7] Move lguest_dma_info into generic lg.h Steven Rostedt
2007-08-09 0:32 ` Steven Rostedt
2007-08-11 3:42 ` [PATCH 0/7] Modify lguest32 to make room for lguest64 Rusty Russell
2007-08-11 3:42 ` Rusty Russell
2007-08-13 9:50 ` Jes Sorensen
2007-08-13 9:50 ` Jes Sorensen
2007-08-13 15:01 ` Jes Sorensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46BB080F.4040905@sgi.com \
--to=jes@sgi.com \
--cc=akpm@linux-foundation.org \
--cc=cotte@de.ibm.com \
--cc=glommer@gmail.com \
--cc=lguest@ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=rusty@rustcorp.com.au \
--cc=sfr@canb.auug.org.au \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.