From: Dean Nelson <dcn@sgi.com>
To: linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, tony.luck@intel.com, jes@sgi.com
Subject: Re: [RFC 1/3] SGI Altix cross partition memory (XPMEM)
Date: Fri, 10 Aug 2007 01:11:04 +0000 [thread overview]
Message-ID: <20070810011104.GB25427@sgi.com> (raw)
In-Reply-To: <20070810010659.GA25427@sgi.com>
This patch exports __put_task_struct as it is needed by XPMEM.
Signed-off-by: Dean Nelson <dcn@sgi.com>
---
One struct file_operations registered by XPMEM, xpmem_open(), calls
'get_task_struct(current->group_leader)' and another, xpmem_flush(), calls
'put_task_struct(tg->group_leader)'. The reason for this is given in the
comment block that appears in xpmem_open().
/*
* Increment 'usage' and 'mm->mm_users' for the current task's thread
* group leader. This ensures that both its task_struct and mm_struct
* will still be around when our thread group exits. (The Linux kernel
* normally tears down the mm_struct prior to calling a module's
* 'flush' function.) Since all XPMEM thread groups must go through
* this path, this extra reference to mm_users also allows us to
* directly inc/dec mm_users in xpmem_ensure_valid_PFNs() and avoid
* mmput() which has a scaling issue with the mmlist_lock.
*/
Index: linux-2.6/kernel/fork.c
=================================--- linux-2.6.orig/kernel/fork.c 2007-08-09 07:07:55.426611601 -0500
+++ linux-2.6/kernel/fork.c 2007-08-09 07:15:43.246391700 -0500
@@ -127,6 +127,7 @@
if (!profile_handoff_task(tsk))
free_task(tsk);
}
+EXPORT_SYMBOL_GPL(__put_task_struct);
void __init fork_init(unsigned long mempages)
{
WARNING: multiple messages have this Message-ID (diff)
From: Dean Nelson <dcn@sgi.com>
To: linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, tony.luck@intel.com, jes@sgi.com
Subject: Re: [RFC 1/3] SGI Altix cross partition memory (XPMEM)
Date: Thu, 9 Aug 2007 20:11:04 -0500 [thread overview]
Message-ID: <20070810011104.GB25427@sgi.com> (raw)
In-Reply-To: <20070810010659.GA25427@sgi.com>
This patch exports __put_task_struct as it is needed by XPMEM.
Signed-off-by: Dean Nelson <dcn@sgi.com>
---
One struct file_operations registered by XPMEM, xpmem_open(), calls
'get_task_struct(current->group_leader)' and another, xpmem_flush(), calls
'put_task_struct(tg->group_leader)'. The reason for this is given in the
comment block that appears in xpmem_open().
/*
* Increment 'usage' and 'mm->mm_users' for the current task's thread
* group leader. This ensures that both its task_struct and mm_struct
* will still be around when our thread group exits. (The Linux kernel
* normally tears down the mm_struct prior to calling a module's
* 'flush' function.) Since all XPMEM thread groups must go through
* this path, this extra reference to mm_users also allows us to
* directly inc/dec mm_users in xpmem_ensure_valid_PFNs() and avoid
* mmput() which has a scaling issue with the mmlist_lock.
*/
Index: linux-2.6/kernel/fork.c
===================================================================
--- linux-2.6.orig/kernel/fork.c 2007-08-09 07:07:55.426611601 -0500
+++ linux-2.6/kernel/fork.c 2007-08-09 07:15:43.246391700 -0500
@@ -127,6 +127,7 @@
if (!profile_handoff_task(tsk))
free_task(tsk);
}
+EXPORT_SYMBOL_GPL(__put_task_struct);
void __init fork_init(unsigned long mempages)
{
WARNING: multiple messages have this Message-ID (diff)
From: Dean Nelson <dcn@sgi.com>
To: linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, tony.luck@intel.com, jes@sgi.com
Subject: Re: [RFC 1/3] SGI Altix cross partition memory (XPMEM)
Date: Thu, 9 Aug 2007 20:11:04 -0500 [thread overview]
Message-ID: <20070810011104.GB25427@sgi.com> (raw)
In-Reply-To: <20070810010659.GA25427@sgi.com>
This patch exports __put_task_struct as it is needed by XPMEM.
Signed-off-by: Dean Nelson <dcn@sgi.com>
---
One struct file_operations registered by XPMEM, xpmem_open(), calls
'get_task_struct(current->group_leader)' and another, xpmem_flush(), calls
'put_task_struct(tg->group_leader)'. The reason for this is given in the
comment block that appears in xpmem_open().
/*
* Increment 'usage' and 'mm->mm_users' for the current task's thread
* group leader. This ensures that both its task_struct and mm_struct
* will still be around when our thread group exits. (The Linux kernel
* normally tears down the mm_struct prior to calling a module's
* 'flush' function.) Since all XPMEM thread groups must go through
* this path, this extra reference to mm_users also allows us to
* directly inc/dec mm_users in xpmem_ensure_valid_PFNs() and avoid
* mmput() which has a scaling issue with the mmlist_lock.
*/
Index: linux-2.6/kernel/fork.c
===================================================================
--- linux-2.6.orig/kernel/fork.c 2007-08-09 07:07:55.426611601 -0500
+++ linux-2.6/kernel/fork.c 2007-08-09 07:15:43.246391700 -0500
@@ -127,6 +127,7 @@
if (!profile_handoff_task(tsk))
free_task(tsk);
}
+EXPORT_SYMBOL_GPL(__put_task_struct);
void __init fork_init(unsigned long mempages)
{
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2007-08-10 1:11 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-10 1:06 [RFC 0/3] SGI Altix cross partition memory (XPMEM) Dean Nelson
2007-08-10 1:06 ` Dean Nelson
2007-08-10 1:06 ` Dean Nelson
2007-08-10 1:11 ` Dean Nelson [this message]
2007-08-10 1:11 ` [RFC 1/3] " Dean Nelson
2007-08-10 1:11 ` Dean Nelson
2007-08-10 1:12 ` [RFC 2/3] " Dean Nelson
2007-08-10 1:12 ` Dean Nelson
2007-08-10 1:12 ` Dean Nelson
2007-08-10 1:14 ` [RFC 3/3] " Dean Nelson
2007-08-10 1:14 ` Dean Nelson
2007-08-10 6:15 ` Andrew Morton
2007-08-10 6:15 ` Andrew Morton
2007-08-10 6:15 ` Andrew Morton
2007-08-22 17:00 ` Dean Nelson
2007-08-22 17:00 ` Dean Nelson
2007-08-22 18:04 ` Andrew Morton
2007-08-22 18:04 ` Andrew Morton
2007-08-22 18:04 ` Andrew Morton
2007-08-22 19:15 ` Dean Nelson
2007-08-22 19:15 ` Dean Nelson
2007-08-22 19:15 ` Dean Nelson
2007-08-22 19:49 ` Andrew Morton
2007-08-22 19:49 ` Andrew Morton
2007-08-22 19:49 ` Andrew Morton
2007-08-23 13:58 ` Andy Whitcroft
2007-08-23 13:58 ` Andy Whitcroft
2007-08-23 13:58 ` Andy Whitcroft
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070810011104.GB25427@sgi.com \
--to=dcn@sgi.com \
--cc=jes@sgi.com \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.