All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Lameter <clameter@sgi.com>
To: linux-mm@kvack.org
Cc: linux-kernel@vger.kernel.org
Cc: akpm@linux-foundation.org
Cc: dkegel@google.com
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: David Miller <davem@davemloft.net>
Cc: Nick Piggin <npiggin@suse.de>
Subject: [RFC 2/3] Use NOMEMALLOC reclaim to allow reclaim if PF_MEMALLOC is set
Date: Tue, 14 Aug 2007 07:21:05 -0700	[thread overview]
Message-ID: <20070814143303.187548996@sgi.com> (raw)
In-Reply-To: 20070814142103.204771292@sgi.com

[-- Attachment #1: reclaim_nomemalloc --]
[-- Type: text/plain, Size: 1632 bytes --]

If we exhaust the reserves in the page allocator when PF_MEMALLOC is set
then no longer give up but call into reclaim with PF_MEMALLOC set.

This is in essence a recursive call back into page reclaim with another
page flag (__GFP_NOMEMALLOC) set. The recursion is bounded since potential
allocations with __PF_NOMEMALLOC set will not enter that branch again.

This means that allocation under PF_MEMALLOC will no longer run out of
memory. Allocations under PF_MEMALLOC will do a limited form of reclaim
instead.

The reclaim is of particular important to stacked filesystems that may
do a lot of allocations in the write path. Reclaim will be working
as long as there are clean file backed pages to reclaim.

Signed-off-by: Christoph Lameter <clameter@sgi.com>

---
 mm/page_alloc.c |   11 +++++++++++
 1 file changed, 11 insertions(+)

Index: linux-2.6/mm/page_alloc.c
===================================================================
--- linux-2.6.orig/mm/page_alloc.c	2007-08-13 23:50:01.000000000 -0700
+++ linux-2.6/mm/page_alloc.c	2007-08-13 23:58:43.000000000 -0700
@@ -1306,6 +1306,17 @@ nofail_alloc:
 				zonelist, ALLOC_NO_WATERMARKS);
 			if (page)
 				goto got_pg;
+			/*
+			 * If we are already in reclaim then the environment
+			 * is already setup. We can simply call
+			 * try_to_get_free_pages(). Just make sure that
+			 * we do not allocate anything.
+			 */
+			if (p->flags & PF_MEMALLOC && wait &&
+				try_to_free_pages(zonelist->zones, order,
+						gfp_mask | __GFP_NOMEMALLOC))
+				goto restart;
+
 			if (gfp_mask & __GFP_NOFAIL) {
 				congestion_wait(WRITE, HZ/50);
 				goto nofail_alloc;

-- 

WARNING: multiple messages have this Message-ID (diff)
From: Christoph Lameter <clameter@sgi.com>
To: linux-mm@kvack.org
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
	dkegel@google.com, Peter Zijlstra <a.p.zijlstra@chello.nl>,
	David Miller <davem@davemloft.net>, Nick Piggin <npiggin@suse.de>
Subject: [RFC 2/3] Use NOMEMALLOC reclaim to allow reclaim if PF_MEMALLOC is set
Date: Tue, 14 Aug 2007 07:21:05 -0700	[thread overview]
Message-ID: <20070814143303.187548996@sgi.com> (raw)
In-Reply-To: 20070814142103.204771292@sgi.com

[-- Attachment #1: reclaim_nomemalloc --]
[-- Type: text/plain, Size: 1858 bytes --]

If we exhaust the reserves in the page allocator when PF_MEMALLOC is set
then no longer give up but call into reclaim with PF_MEMALLOC set.

This is in essence a recursive call back into page reclaim with another
page flag (__GFP_NOMEMALLOC) set. The recursion is bounded since potential
allocations with __PF_NOMEMALLOC set will not enter that branch again.

This means that allocation under PF_MEMALLOC will no longer run out of
memory. Allocations under PF_MEMALLOC will do a limited form of reclaim
instead.

The reclaim is of particular important to stacked filesystems that may
do a lot of allocations in the write path. Reclaim will be working
as long as there are clean file backed pages to reclaim.

Signed-off-by: Christoph Lameter <clameter@sgi.com>

---
 mm/page_alloc.c |   11 +++++++++++
 1 file changed, 11 insertions(+)

Index: linux-2.6/mm/page_alloc.c
===================================================================
--- linux-2.6.orig/mm/page_alloc.c	2007-08-13 23:50:01.000000000 -0700
+++ linux-2.6/mm/page_alloc.c	2007-08-13 23:58:43.000000000 -0700
@@ -1306,6 +1306,17 @@ nofail_alloc:
 				zonelist, ALLOC_NO_WATERMARKS);
 			if (page)
 				goto got_pg;
+			/*
+			 * If we are already in reclaim then the environment
+			 * is already setup. We can simply call
+			 * try_to_get_free_pages(). Just make sure that
+			 * we do not allocate anything.
+			 */
+			if (p->flags & PF_MEMALLOC && wait &&
+				try_to_free_pages(zonelist->zones, order,
+						gfp_mask | __GFP_NOMEMALLOC))
+				goto restart;
+
 			if (gfp_mask & __GFP_NOFAIL) {
 				congestion_wait(WRITE, HZ/50);
 				goto nofail_alloc;

-- 

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2007-08-14 14:33 UTC|newest]

Thread overview: 108+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-14 14:21 [RFC 0/3] Recursive reclaim (on __PF_MEMALLOC) Christoph Lameter
2007-08-14 14:21 ` Christoph Lameter
2007-08-14 14:21 ` [RFC 1/3] Allow reclaim via __GFP_NOMEMALLOC reclaim Christoph Lameter
2007-08-14 14:21   ` Christoph Lameter
2007-08-14 14:21 ` Christoph Lameter [this message]
2007-08-14 14:21   ` [RFC 2/3] Use NOMEMALLOC reclaim to allow reclaim if PF_MEMALLOC is set Christoph Lameter
2007-08-14 14:21 ` [RFC 3/3] Test code for PF_MEMALLOC reclaim Christoph Lameter
2007-08-14 14:21   ` Christoph Lameter
2007-08-14 14:36 ` [RFC 0/3] Recursive reclaim (on __PF_MEMALLOC) Peter Zijlstra
2007-08-14 14:36   ` Peter Zijlstra
2007-08-14 15:29   ` Christoph Lameter
2007-08-14 15:29     ` Christoph Lameter
2007-08-14 19:32     ` Peter Zijlstra
2007-08-14 19:32       ` Peter Zijlstra
2007-08-14 19:41       ` Christoph Lameter
2007-08-14 19:41         ` Christoph Lameter
2007-08-15 12:22 ` Nick Piggin
2007-08-15 12:22   ` Nick Piggin
2007-08-15 13:12   ` Peter Zijlstra
2007-08-15 14:15     ` Andi Kleen
2007-08-15 14:15       ` Andi Kleen
2007-08-15 13:55       ` Peter Zijlstra
2007-08-15 14:34         ` Andi Kleen
2007-08-15 14:34           ` Andi Kleen
2007-08-15 20:32         ` Christoph Lameter
2007-08-15 20:32           ` Christoph Lameter
2007-08-15 20:29     ` Christoph Lameter
2007-08-15 20:29       ` Christoph Lameter
2007-08-16  3:29     ` Nick Piggin
2007-08-16  3:29       ` Nick Piggin
2007-08-16 20:27       ` Christoph Lameter
2007-08-16 20:27         ` Christoph Lameter
2007-08-20  3:51       ` Peter Zijlstra
2007-08-20 19:15         ` Christoph Lameter
2007-08-20 19:15           ` Christoph Lameter
2007-08-21  0:32           ` Nick Piggin
2007-08-21  0:32             ` Nick Piggin
2007-08-21  0:28         ` Nick Piggin
2007-08-21  0:28           ` Nick Piggin
2007-08-21 15:29           ` Peter Zijlstra
2007-08-23  3:02             ` Nick Piggin
2007-08-23  3:02               ` Nick Piggin
2007-09-12 22:39           ` Christoph Lameter
2007-09-12 22:39             ` Christoph Lameter
2007-09-05  9:20 ` Daniel Phillips
2007-09-05  9:20   ` Daniel Phillips
2007-09-05 10:42   ` Christoph Lameter
2007-09-05 10:42     ` Christoph Lameter
2007-09-05 11:42     ` Nick Piggin
2007-09-05 11:42       ` Nick Piggin
2007-09-05 12:14       ` Christoph Lameter
2007-09-05 12:14         ` Christoph Lameter
2007-09-05 12:19         ` Nick Piggin
2007-09-05 12:19           ` Nick Piggin
2007-09-10 19:29           ` Christoph Lameter
2007-09-10 19:29             ` Christoph Lameter
2007-09-10 19:37             ` Peter Zijlstra
2007-09-10 19:41               ` Christoph Lameter
2007-09-10 19:41                 ` Christoph Lameter
2007-09-10 19:55                 ` Peter Zijlstra
2007-09-10 20:17                   ` Christoph Lameter
2007-09-10 20:17                     ` Christoph Lameter
2007-09-10 20:48                     ` Peter Zijlstra
2007-09-11  7:41             ` Nick Piggin
2007-09-11  7:41               ` Nick Piggin
2007-09-12 10:52         ` Peter Zijlstra
2007-09-12 22:47           ` Christoph Lameter
2007-09-12 22:47             ` Christoph Lameter
2007-09-13  8:19             ` Peter Zijlstra
2007-09-13 18:32               ` Christoph Lameter
2007-09-13 18:32                 ` Christoph Lameter
2007-09-13 19:24                 ` Peter Zijlstra
2007-09-13 19:24                   ` Peter Zijlstra
2007-09-05 16:16     ` Daniel Phillips
2007-09-05 16:16       ` Daniel Phillips
2007-09-08  5:12       ` Mike Snitzer
2007-09-08  5:12         ` Mike Snitzer
2007-09-18  0:28         ` Daniel Phillips
2007-09-18  0:28           ` Daniel Phillips
2007-09-18  3:27           ` Mike Snitzer
2007-09-18  3:27             ` Mike Snitzer
2007-09-18  5:37             ` Daniel Phillips
2007-09-18  9:30             ` Peter Zijlstra
2007-09-18  9:30               ` Peter Zijlstra
     [not found]             ` <200709172211.26493.phillips@phunq.net>
2007-09-18  8:11               ` Wouter Verhelst
2007-09-18  8:11                 ` Wouter Verhelst
2007-09-18  9:58               ` Peter Zijlstra
2007-09-18  9:58                 ` Peter Zijlstra
2007-09-18 16:56                 ` Daniel Phillips
2007-09-18 16:56                   ` Daniel Phillips
2007-09-18 19:16                   ` Peter Zijlstra
2007-09-18 19:16                     ` Peter Zijlstra
2007-09-18 18:40             ` Daniel Phillips
2007-09-18 20:13               ` Mike Snitzer
2007-09-10 19:25       ` Christoph Lameter
2007-09-10 19:25         ` Christoph Lameter
2007-09-10 19:55         ` Peter Zijlstra
2007-09-10 20:22           ` Christoph Lameter
2007-09-10 20:22             ` Christoph Lameter
2007-09-10 20:48             ` Peter Zijlstra
2007-10-26 17:44               ` Pavel Machek
2007-10-26 17:44                 ` Pavel Machek
2007-10-26 17:55                 ` Christoph Lameter
2007-10-26 17:55                   ` Christoph Lameter
2007-10-27 22:58                   ` Daniel Phillips
2007-10-27 22:58                     ` Daniel Phillips
2007-10-27 23:08                 ` Daniel Phillips
2007-10-27 23:08                   ` Daniel Phillips

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070814143303.187548996@sgi.com \
    --to=clameter@sgi.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.