From: Patrick McHardy <kaber@trash.net>
To: davem@davemloft.net
Cc: netfilter-devel@lists.netfilter.org, Patrick McHardy <kaber@trash.net>
Subject: [NETFILTER 01/04]: netfilter: xt_u32 bug correction
Date: Tue, 14 Aug 2007 18:40:14 +0200 (MEST) [thread overview]
Message-ID: <20070814164006.14668.26611.sendpatchset@localhost.localdomain> (raw)
In-Reply-To: <20070814164004.14668.43960.sendpatchset@localhost.localdomain>
[NETFILTER]: netfilter: xt_u32 bug correction
An extraneous ";" makes xt_u32 match useless
Signed-off-by: Eric Dumazet <dada1@cosmosbay.com>
Signed-off-by: Patrick McHardy <kaber@trash.net>
---
commit 4cbeda3b69e71c535ea820f5a94f4232598e3eea
tree e104d542dfa81fbec1656bce46a32bd0d3cdf10c
parent 39d3520c92cf7a28c07229ca00cc35a1e8026c77
author Eric Dumazet <dada1@cosmosbay.com> Tue, 14 Aug 2007 18:35:02 +0200
committer Patrick McHardy <kaber@trash.net> Tue, 14 Aug 2007 18:35:02 +0200
net/netfilter/xt_u32.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/netfilter/xt_u32.c b/net/netfilter/xt_u32.c
index 74f9b14..bec4279 100644
--- a/net/netfilter/xt_u32.c
+++ b/net/netfilter/xt_u32.c
@@ -36,7 +36,7 @@ static bool u32_match_it(const struct xt_u32 *data,
at = 0;
pos = ct->location[0].number;
- if (skb->len < 4 || pos > skb->len - 4);
+ if (skb->len < 4 || pos > skb->len - 4)
return false;
ret = skb_copy_bits(skb, pos, &n, sizeof(n));
next prev parent reply other threads:[~2007-08-14 16:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-14 16:40 [NETFILTER 00/04]: Netfilter fixes Patrick McHardy
2007-08-14 16:40 ` Patrick McHardy [this message]
2007-08-14 17:18 ` [NETFILTER 01/04]: netfilter: xt_u32 bug correction Jan Engelhardt
2007-08-14 16:40 ` [NETFILTER 02/04]: nf_conntrack_sip: check sname != NULL before calling strncmp Patrick McHardy
2007-08-14 16:40 ` [NETFILTER 03/04]: nf_conntrack_sip: fix SIP-URI parsing Patrick McHardy
2007-08-14 16:40 ` [NETFILTER 04/04]: nf_nat_sip: don't drop short packets Patrick McHardy
2007-08-14 20:15 ` [NETFILTER 00/04]: Netfilter fixes David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070814164006.14668.26611.sendpatchset@localhost.localdomain \
--to=kaber@trash.net \
--cc=davem@davemloft.net \
--cc=netfilter-devel@lists.netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.