All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: davem@davemloft.net
Cc: netfilter-devel@lists.netfilter.org, Patrick McHardy <kaber@trash.net>
Subject: [NETFILTER 04/04]: nf_nat_sip: don't drop short packets
Date: Tue, 14 Aug 2007 18:40:19 +0200 (MEST)	[thread overview]
Message-ID: <20070814164011.14668.44375.sendpatchset@localhost.localdomain> (raw)
In-Reply-To: <20070814164004.14668.43960.sendpatchset@localhost.localdomain>

[NETFILTER]: nf_nat_sip: don't drop short packets

Don't drop packets shorter than "SIP/2.0", just ignore them. Keep-alives
can validly be shorter for example.

Signed-off-by: Patrick McHardy <kaber@trash.net>

---
commit 12ad6c49be7b0cb1e9f32750e34cde5d29d40a48
tree 6dc3ff60e52adc58a3a02d725f819cc6811b1664
parent 492d0e43049e7f420c1c64044ab57abf278fbead
author Patrick McHardy <kaber@trash.net> Tue, 14 Aug 2007 18:37:58 +0200
committer Patrick McHardy <kaber@trash.net> Tue, 14 Aug 2007 18:37:58 +0200

 net/ipv4/netfilter/nf_nat_sip.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/net/ipv4/netfilter/nf_nat_sip.c b/net/ipv4/netfilter/nf_nat_sip.c
index a889ec3..e14d419 100644
--- a/net/ipv4/netfilter/nf_nat_sip.c
+++ b/net/ipv4/netfilter/nf_nat_sip.c
@@ -104,7 +104,7 @@ static unsigned int ip_nat_sip(struct sk_buff **pskb,
 	dataoff = ip_hdrlen(*pskb) + sizeof(struct udphdr);
 	datalen = (*pskb)->len - dataoff;
 	if (datalen < sizeof("SIP/2.0") - 1)
-		return NF_DROP;
+		return NF_ACCEPT;
 
 	addr_map_init(ct, &map);
 

  parent reply	other threads:[~2007-08-14 16:40 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-14 16:40 [NETFILTER 00/04]: Netfilter fixes Patrick McHardy
2007-08-14 16:40 ` [NETFILTER 01/04]: netfilter: xt_u32 bug correction Patrick McHardy
2007-08-14 17:18   ` Jan Engelhardt
2007-08-14 16:40 ` [NETFILTER 02/04]: nf_conntrack_sip: check sname != NULL before calling strncmp Patrick McHardy
2007-08-14 16:40 ` [NETFILTER 03/04]: nf_conntrack_sip: fix SIP-URI parsing Patrick McHardy
2007-08-14 16:40 ` Patrick McHardy [this message]
2007-08-14 20:15 ` [NETFILTER 00/04]: Netfilter fixes David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070814164011.14668.44375.sendpatchset@localhost.localdomain \
    --to=kaber@trash.net \
    --cc=davem@davemloft.net \
    --cc=netfilter-devel@lists.netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.