From: Tony Lindgren <tony@atomide.com>
To: David Brownell <david-b@pacbell.net>
Cc: linux-omap-open-source@linux.omap.com
Subject: Re: [patch 2.6.23-rc2-omap1] remove useless/wrong P20_24XX_TSC_IRQ mux
Date: Wed, 15 Aug 2007 03:54:59 -0700 [thread overview]
Message-ID: <20070815105458.GJ19754@atomide.com> (raw)
In-Reply-To: <200708132247.13166.david-b@pacbell.net>
* David Brownell <david-b@pacbell.net> [070813 23:12]:
> Remove bogus TSC_IRQ pinmux; it's not used, there's no pin
> dedicated for touchscreen (or other TSC chip) purposes, and
> this doesn't even look right for P20 (0x10b not 0x108, plus
> an IRQ would need to be a GPIO i.e. mux 3 not mux 0).
>
> Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
>
> --- h4.orig/arch/arm/mach-omap2/mux.c 2007-08-13 12:31:32.000000000 -0700
> +++ h4/arch/arm/mach-omap2/mux.c 2007-08-13 12:32:12.000000000 -0700
> @@ -106,9 +106,6 @@ MUX_CFG_24XX("G4_242X_DMAREQ3", 0x073,
> MUX_CFG_24XX("D3_242X_DMAREQ4", 0x072, 2, 0, 0, 1)
> MUX_CFG_24XX("E3_242X_DMAREQ5", 0x071, 2, 0, 0, 1)
>
> -/* TSC IRQ */
> -MUX_CFG_24XX("P20_24XX_TSC_IRQ", 0x108, 0, 0, 0, 1)
> -
> /* UART3 */
> MUX_CFG_24XX("K15_24XX_UART3_TX", 0x118, 0, 0, 0, 1)
> MUX_CFG_24XX("K14_24XX_UART3_RX", 0x119, 0, 0, 0, 1)
> --- h4.orig/include/asm-arm/arch-omap/mux.h 2007-08-13 12:31:32.000000000 -0700
> +++ h4/include/asm-arm/arch-omap/mux.h 2007-08-13 12:32:12.000000000 -0700
> @@ -498,8 +498,6 @@ enum omap24xx_index {
> D3_242X_DMAREQ4,
> E3_242X_DMAREQ5,
>
> - P20_24XX_TSC_IRQ,
> -
> /* UART3 */
> K15_24XX_UART3_TX,
> K14_24XX_UART3_RX,
Pushing today.
Tony
prev parent reply other threads:[~2007-08-15 10:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-14 5:47 [patch 2.6.23-rc2-omap1] remove useless/wrong P20_24XX_TSC_IRQ mux David Brownell
2007-08-15 10:54 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070815105458.GJ19754@atomide.com \
--to=tony@atomide.com \
--cc=david-b@pacbell.net \
--cc=linux-omap-open-source@linux.omap.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.