All of lore.kernel.org
 help / color / mirror / Atom feed
* [patch 2.6.23-rc2-omap1] remove useless/wrong P20_24XX_TSC_IRQ mux
@ 2007-08-14  5:47 David Brownell
  2007-08-15 10:54 ` Tony Lindgren
  0 siblings, 1 reply; 2+ messages in thread
From: David Brownell @ 2007-08-14  5:47 UTC (permalink / raw)
  To: linux-omap-open-source

Remove bogus TSC_IRQ pinmux; it's not used, there's no pin
dedicated for touchscreen (or other TSC chip) purposes, and
this doesn't even look right for P20 (0x10b not 0x108, plus
an IRQ would need to be a GPIO i.e. mux 3 not mux 0).

Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>

--- h4.orig/arch/arm/mach-omap2/mux.c	2007-08-13 12:31:32.000000000 -0700
+++ h4/arch/arm/mach-omap2/mux.c	2007-08-13 12:32:12.000000000 -0700
@@ -106,9 +106,6 @@ MUX_CFG_24XX("G4_242X_DMAREQ3",		0x073,	
 MUX_CFG_24XX("D3_242X_DMAREQ4",		0x072,	2,	0,	0,	1)
 MUX_CFG_24XX("E3_242X_DMAREQ5",		0x071,	2,	0,	0,	1)
 
-/* TSC IRQ */
-MUX_CFG_24XX("P20_24XX_TSC_IRQ",	0x108,	0,	0,	0,	1)
-
 /* UART3 */
 MUX_CFG_24XX("K15_24XX_UART3_TX",	0x118,	0,	0,	0,	1)
 MUX_CFG_24XX("K14_24XX_UART3_RX",	0x119,	0,	0,	0,	1)
--- h4.orig/include/asm-arm/arch-omap/mux.h	2007-08-13 12:31:32.000000000 -0700
+++ h4/include/asm-arm/arch-omap/mux.h	2007-08-13 12:32:12.000000000 -0700
@@ -498,8 +498,6 @@ enum omap24xx_index {
 	D3_242X_DMAREQ4,
 	E3_242X_DMAREQ5,
 
-	P20_24XX_TSC_IRQ,
-
 	/* UART3 */
 	K15_24XX_UART3_TX,
 	K14_24XX_UART3_RX,

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [patch 2.6.23-rc2-omap1] remove useless/wrong P20_24XX_TSC_IRQ mux
  2007-08-14  5:47 [patch 2.6.23-rc2-omap1] remove useless/wrong P20_24XX_TSC_IRQ mux David Brownell
@ 2007-08-15 10:54 ` Tony Lindgren
  0 siblings, 0 replies; 2+ messages in thread
From: Tony Lindgren @ 2007-08-15 10:54 UTC (permalink / raw)
  To: David Brownell; +Cc: linux-omap-open-source

* David Brownell <david-b@pacbell.net> [070813 23:12]:
> Remove bogus TSC_IRQ pinmux; it's not used, there's no pin
> dedicated for touchscreen (or other TSC chip) purposes, and
> this doesn't even look right for P20 (0x10b not 0x108, plus
> an IRQ would need to be a GPIO i.e. mux 3 not mux 0).
> 
> Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
> 
> --- h4.orig/arch/arm/mach-omap2/mux.c	2007-08-13 12:31:32.000000000 -0700
> +++ h4/arch/arm/mach-omap2/mux.c	2007-08-13 12:32:12.000000000 -0700
> @@ -106,9 +106,6 @@ MUX_CFG_24XX("G4_242X_DMAREQ3",		0x073,	
>  MUX_CFG_24XX("D3_242X_DMAREQ4",		0x072,	2,	0,	0,	1)
>  MUX_CFG_24XX("E3_242X_DMAREQ5",		0x071,	2,	0,	0,	1)
>  
> -/* TSC IRQ */
> -MUX_CFG_24XX("P20_24XX_TSC_IRQ",	0x108,	0,	0,	0,	1)
> -
>  /* UART3 */
>  MUX_CFG_24XX("K15_24XX_UART3_TX",	0x118,	0,	0,	0,	1)
>  MUX_CFG_24XX("K14_24XX_UART3_RX",	0x119,	0,	0,	0,	1)
> --- h4.orig/include/asm-arm/arch-omap/mux.h	2007-08-13 12:31:32.000000000 -0700
> +++ h4/include/asm-arm/arch-omap/mux.h	2007-08-13 12:32:12.000000000 -0700
> @@ -498,8 +498,6 @@ enum omap24xx_index {
>  	D3_242X_DMAREQ4,
>  	E3_242X_DMAREQ5,
>  
> -	P20_24XX_TSC_IRQ,
> -
>  	/* UART3 */
>  	K15_24XX_UART3_TX,
>  	K14_24XX_UART3_RX,

Pushing today.

Tony

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2007-08-15 10:54 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-08-14  5:47 [patch 2.6.23-rc2-omap1] remove useless/wrong P20_24XX_TSC_IRQ mux David Brownell
2007-08-15 10:54 ` Tony Lindgren

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.