All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <ak@suse.de>
To: Len Brown <lenb@kernel.org>
Cc: Andi Kleen <ak@suse.de>,
	linux-acpi@vger.kernel.org,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ACPI: boot correctly with "nosmp" or "maxcpus=0"
Date: Thu, 16 Aug 2007 21:36:49 +0200	[thread overview]
Message-ID: <20070816193649.GA16680@bingen.suse.de> (raw)
In-Reply-To: <200708160332.30732.lenb@kernel.org>

> @@ -157,10 +162,13 @@ early_param("nosmp", nosmp);
>  static int __init maxcpus(char *str)
>  {
>  	get_option(&str, &max_cpus);
> -	return 1;
> +	if (max_cpus == 0)
> +		disable_ioapic_setup();

I must say I never liked that maxcpus=0 ... does disable the APIC
too. There can be situations where you want only a single CPU,
but still full APICs because modern systems don't boot without. 

It's the old traditional documented semantics though,
but on the other hand if it never worked with ACPI i guess people are
not relying on it.

So perhaps it would be better to change that? 
Or add a new option to limit CPUs without disabling ACPIC?

-Andi

  reply	other threads:[~2007-08-16 18:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-16  7:32 [PATCH] ACPI: boot correctly with "nosmp" or "maxcpus=0" Len Brown
2007-08-16 19:36 ` Andi Kleen [this message]
2007-08-16 23:06   ` Len Brown
2007-08-16 23:25     ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070816193649.GA16680@bingen.suse.de \
    --to=ak@suse.de \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.